emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rainer M Krug <Rainer@krugs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R
Date: Mon, 30 Jun 2014 14:36:54 +0200	[thread overview]
Message-ID: <87ionimv4p.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m24mz2hcpi.fsf@krugs.de> (Rainer M. Krug's message of "Mon, 30 Jun 2014 13:13:45 +0200")

Hello,

Rainer M Krug <Rainer@krugs.de> writes:

> Attached please find two patches ready for application to fix that table
> variables were not usable adter tangling as temporary files were used.
> These patches were discussed in the thread "[babel][PATCHES] ob-R
> patches for review"

I have not much to say about the feature, since I don't use R. Usual
nitpicking follows.

> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L"))
> +      (if (floatp value) (format "%s <- %s" name value)
> +	(if (stringp value) (format "%s <- %S" name value) 
> +	  (format "%s <- %S" name (prin1-to-string value)))))))

I think a `cond' would be more readable here.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2014-06-30 12:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 11:13 [patch] [babel] Patches to fix tangling and variable transfer of tables in R Rainer M Krug
2014-06-30 12:36 ` Nicolas Goaziou [this message]
2014-07-01 10:36   ` Rainer M Krug
2014-07-01 10:51   ` Rainer M Krug
2014-07-08 10:23     ` Rainer M Krug
2014-07-27 19:29     ` Charles Berry
2014-07-27 22:01     ` Bastien
2014-07-29 15:52       ` Rainer M Krug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ionimv4p.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=Rainer@krugs.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).