From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch] [babel] Patches to fix tangling and variable transfer of tables in R Date: Mon, 30 Jun 2014 14:36:54 +0200 Message-ID: <87ionimv4p.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1aoq-0005co-Jv for emacs-orgmode@gnu.org; Mon, 30 Jun 2014 08:36:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1aoi-0001u9-Bi for emacs-orgmode@gnu.org; Mon, 30 Jun 2014 08:36:24 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1aoi-0001u5-6P for emacs-orgmode@gnu.org; Mon, 30 Jun 2014 08:36:16 -0400 In-Reply-To: (Rainer M. Krug's message of "Mon, 30 Jun 2014 13:13:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rainer M Krug Cc: emacs-orgmode@gnu.org Hello, Rainer M Krug writes: > Attached please find two patches ready for application to fix that table > variables were not usable adter tangling as temporary files were used. > These patches were discussed in the thread "[babel][PATCHES] ob-R > patches for review" I have not much to say about the feature, since I don't use R. Usual nitpicking follows. > + (if (integerp value) (format "%s <- %s" name (concat (number-to-string value) "L")) > + (if (floatp value) (format "%s <- %s" name value) > + (if (stringp value) (format "%s <- %S" name value) > + (format "%s <- %S" name (prin1-to-string value))))))) I think a `cond' would be more readable here. Regards, -- Nicolas Goaziou