* [PATCH] ox-html.el: Remove superflous whitespace
@ 2015-11-30 6:26 Ruben Maher
2015-11-30 14:58 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Ruben Maher @ 2015-11-30 6:26 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Ruben Maher
* lisp/ox-html.el: Remove superfluous whitespace from meta tags, put
there by `org-html--buld-meta-info' and `org-html--build-head'.
`org-html-close-tag' already inserts a space, so it is not necessary
to add another. Previously these affected tags would look like
<meta name="generator" content="Org-mode" />.
---
lisp/ox-html.el | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index effd387..8f9fe99 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1711,9 +1711,9 @@ INFO is a plist used as a communication channel."
" -->\n")))
(format
(if (org-html-html5-p info)
- (org-html-close-tag "meta" " charset=\"%s\"" info)
+ (org-html-close-tag "meta" "charset=\"%s\"" info)
(org-html-close-tag
- "meta" " http-equiv=\"Content-Type\" content=\"text/html;charset=%s\""
+ "meta" "http-equiv=\"Content-Type\" content=\"text/html;charset=%s\""
info))
charset) "\n"
(let ((viewport-options
@@ -1723,33 +1723,33 @@ INFO is a plist used as a communication channel."
(concat
(org-html-close-tag
"meta"
- (format " name=\"viewport\" content=\"%s\""
+ (format "name=\"viewport\" content=\"%s\""
(mapconcat
(lambda (elm) (format "%s=%s" (car elm) (cadr elm)))
viewport-options ", "))
info)
"\n")))
(format "<title>%s</title>\n" title)
- (org-html-close-tag "meta" " name=\"generator\" content=\"Org-mode\"" info)
+ (org-html-close-tag "meta" "name=\"generator\" content=\"Org-mode\"" info)
"\n"
(and (org-string-nw-p author)
(concat
(org-html-close-tag "meta"
- (format " name=\"author\" content=\"%s\""
+ (format "name=\"author\" content=\"%s\""
(funcall protect-string author))
info)
"\n"))
(and (org-string-nw-p description)
(concat
(org-html-close-tag "meta"
- (format " name=\"description\" content=\"%s\"\n"
+ (format "name=\"description\" content=\"%s\"\n"
(funcall protect-string description))
info)
"\n"))
(and (org-string-nw-p keywords)
(concat
(org-html-close-tag "meta"
- (format " name=\"keywords\" content=\"%s\""
+ (format "name=\"keywords\" content=\"%s\""
(funcall protect-string keywords))
info)
"\n")))))
@@ -1766,7 +1766,7 @@ INFO is a plist used as a communication channel."
(when (and (plist-get info :html-htmlized-css-url)
(eq org-html-htmlize-output-type 'css))
(org-html-close-tag "link"
- (format " rel=\"stylesheet\" href=\"%s\" type=\"text/css\""
+ (format "rel=\"stylesheet\" href=\"%s\" type=\"text/css\""
(plist-get info :html-htmlized-css-url))
info))
(when (plist-get info :html-head-include-scripts) org-html-scripts))))
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ox-html.el: Remove superflous whitespace
2015-11-30 6:26 [PATCH] ox-html.el: Remove superflous whitespace Ruben Maher
@ 2015-11-30 14:58 ` Nicolas Goaziou
2015-11-30 20:45 ` Ruben Maher
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2015-11-30 14:58 UTC (permalink / raw)
To: Ruben Maher; +Cc: emacs-orgmode
Hello,
Ruben Maher <r@rkm.id.au> writes:
> * lisp/ox-html.el: Remove superfluous whitespace from meta tags, put
> there by `org-html--buld-meta-info' and `org-html--build-head'.
> `org-html-close-tag' already inserts a space, so it is not necessary
> to add another. Previously these affected tags would look like
> <meta name="generator" content="Org-mode" />.
Thank you for the patch.
However, you need to add TINYCHANGE at the end of the commit message if
you haven't signed FSF papers yet.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ox-html.el: Remove superflous whitespace
2015-11-30 14:58 ` Nicolas Goaziou
@ 2015-11-30 20:45 ` Ruben Maher
2015-12-01 22:37 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Ruben Maher @ 2015-11-30 20:45 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Ruben Maher
* lisp/ox-html.el: Remove superfluous whitespace from meta tags, put
there by `org-html--buld-meta-info' and `org-html--build-head'.
`org-html-close-tag' already inserts a space, so it is not necessary
to add another. Previously these affected tags would look like
<meta name="generator" content="Org-mode" />.
TINYCHANGE
---
lisp/ox-html.el | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index effd387..8f9fe99 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -1711,9 +1711,9 @@ INFO is a plist used as a communication channel."
" -->\n")))
(format
(if (org-html-html5-p info)
- (org-html-close-tag "meta" " charset=\"%s\"" info)
+ (org-html-close-tag "meta" "charset=\"%s\"" info)
(org-html-close-tag
- "meta" " http-equiv=\"Content-Type\" content=\"text/html;charset=%s\""
+ "meta" "http-equiv=\"Content-Type\" content=\"text/html;charset=%s\""
info))
charset) "\n"
(let ((viewport-options
@@ -1723,33 +1723,33 @@ INFO is a plist used as a communication channel."
(concat
(org-html-close-tag
"meta"
- (format " name=\"viewport\" content=\"%s\""
+ (format "name=\"viewport\" content=\"%s\""
(mapconcat
(lambda (elm) (format "%s=%s" (car elm) (cadr elm)))
viewport-options ", "))
info)
"\n")))
(format "<title>%s</title>\n" title)
- (org-html-close-tag "meta" " name=\"generator\" content=\"Org-mode\"" info)
+ (org-html-close-tag "meta" "name=\"generator\" content=\"Org-mode\"" info)
"\n"
(and (org-string-nw-p author)
(concat
(org-html-close-tag "meta"
- (format " name=\"author\" content=\"%s\""
+ (format "name=\"author\" content=\"%s\""
(funcall protect-string author))
info)
"\n"))
(and (org-string-nw-p description)
(concat
(org-html-close-tag "meta"
- (format " name=\"description\" content=\"%s\"\n"
+ (format "name=\"description\" content=\"%s\"\n"
(funcall protect-string description))
info)
"\n"))
(and (org-string-nw-p keywords)
(concat
(org-html-close-tag "meta"
- (format " name=\"keywords\" content=\"%s\""
+ (format "name=\"keywords\" content=\"%s\""
(funcall protect-string keywords))
info)
"\n")))))
@@ -1766,7 +1766,7 @@ INFO is a plist used as a communication channel."
(when (and (plist-get info :html-htmlized-css-url)
(eq org-html-htmlize-output-type 'css))
(org-html-close-tag "link"
- (format " rel=\"stylesheet\" href=\"%s\" type=\"text/css\""
+ (format "rel=\"stylesheet\" href=\"%s\" type=\"text/css\""
(plist-get info :html-htmlized-css-url))
info))
(when (plist-get info :html-head-include-scripts) org-html-scripts))))
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ox-html.el: Remove superflous whitespace
2015-11-30 20:45 ` Ruben Maher
@ 2015-12-01 22:37 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2015-12-01 22:37 UTC (permalink / raw)
To: Ruben Maher; +Cc: emacs-orgmode
Hello,
Ruben Maher <r@rkm.id.au> writes:
> * lisp/ox-html.el: Remove superfluous whitespace from meta tags, put
> there by `org-html--buld-meta-info' and `org-html--build-head'.
> `org-html-close-tag' already inserts a space, so it is not necessary
> to add another. Previously these affected tags would look like
> <meta name="generator" content="Org-mode" />.
>
> TINYCHANGE
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-01 22:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30 6:26 [PATCH] ox-html.el: Remove superflous whitespace Ruben Maher
2015-11-30 14:58 ` Nicolas Goaziou
2015-11-30 20:45 ` Ruben Maher
2015-12-01 22:37 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).