From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eduardo Bellani <ebellani@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Enable table with fields containing commas to be used as arguments to sqlite source blocks, fix ox-taskjuggler broken call.
Date: Fri, 01 Sep 2017 23:01:49 +0200 [thread overview]
Message-ID: <87inh22kw2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87wp5imjug.fsf@brickabode.com> (Eduardo Bellani's message of "Fri, 01 Sep 2017 14:04:07 -0300")
Hello,
Eduardo Bellani <ebellani@gmail.com> writes:
> ob-sqlite.el: Enable table with fields containing commas to be used as
> arguments to sqlite source blocks
Thank you!
Could you split this into 2 patches since "ob-sqlite" and
"ox-taskjuggler" are unrelated.
> * testing/examples/ob-sqlite-test.org: Adds an example to be used in
> the sqlite test above.
I suggest to write a self-contained test. IOW, prefer
`org-test-with-temp-text' instead of `org-test-at-id'. This is much
easier to debug when something breaks.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-09-01 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 17:04 [PATCH] Enable table with fields containing commas to be used as arguments to sqlite source blocks, fix ox-taskjuggler broken call Eduardo Bellani
2017-09-01 21:01 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inh22kw2.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=ebellani@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).