From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Enable table with fields containing commas to be used as arguments to sqlite source blocks, fix ox-taskjuggler broken call. Date: Fri, 01 Sep 2017 23:01:49 +0200 Message-ID: <87inh22kw2.fsf@nicolasgoaziou.fr> References: <87wp5imjug.fsf@brickabode.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnt4e-0007KG-NT for emacs-orgmode@gnu.org; Fri, 01 Sep 2017 17:02:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnt4b-00055T-Mz for emacs-orgmode@gnu.org; Fri, 01 Sep 2017 17:01:56 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:34529) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnt4b-00054s-GO for emacs-orgmode@gnu.org; Fri, 01 Sep 2017 17:01:53 -0400 In-Reply-To: <87wp5imjug.fsf@brickabode.com> (Eduardo Bellani's message of "Fri, 01 Sep 2017 14:04:07 -0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Eduardo Bellani Cc: org mode Hello, Eduardo Bellani writes: > ob-sqlite.el: Enable table with fields containing commas to be used as > arguments to sqlite source blocks Thank you! Could you split this into 2 patches since "ob-sqlite" and "ox-taskjuggler" are unrelated. > * testing/examples/ob-sqlite-test.org: Adds an example to be used in > the sqlite test above. I suggest to write a self-contained test. IOW, prefer `org-test-with-temp-text' instead of `org-test-at-id'. This is much easier to debug when something breaks. Regards, -- Nicolas Goaziou