From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Update statistic cookies when archiving
Date: Sun, 03 Sep 2017 10:02:10 +0200 [thread overview]
Message-ID: <87inh0mcql.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87mv6cyi6z.fsf@gmail.com> (Jay Kamat's message of "Sat, 02 Sep 2017 16:11:16 -0400")
Hello,
Jay Kamat <jaygkamat@gmail.com> writes:
> Sorry, forgot to actually attach the patch, here it is.
>
> From 95cdfa8c3ec81b3a0763b68044611c10a4dadc29 Mon Sep 17 00:00:00 2001
> From: Jay Kamat <jaygkamat@gmail.com>
> Date: Sat, 2 Sep 2017 15:57:36 -0400
> Subject: [PATCH] org-archive.el: Update statistic cookies when
> archiving
Thank you!
Be warned that we're in a feature-freeze phase. It will have to wait for
Org 9.1 before being merged.
> + ;; Go to parent, even if no children exist
Nitpick: Missing final dot.
> + (org-up-heading-safe)
> + ;; Update cookie of parent
Ditto.
> + (org-update-statistics-cookies nil)))
> (message "Subtree archived %s"
> (if (eq this-buffer buffer)
> (concat "under heading: " heading)
> @@ -470,6 +476,9 @@ Archiving time is retained in the ARCHIVE_TIME node property."
> (outline-hide-subtree)
> (org-cycle-show-empty-lines 'folded)
> (goto-char pos)))
> + (when org-provide-todo-statistics
> + ;; update todo statistics of parent
Ditto. Missing capital, too.
> + (org-update-parent-todo-statistics))
> (org-reveal)
> (if (looking-at "^[ \t]*$")
> (outline-next-visible-heading 1))))
Could you provide some tests and an ORG-NEWS entry? For the latter, you
can start a new "Version 9.2" top heading.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-09-03 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 20:09 [PATCH] Update statistic cookies when archiving Jay Kamat
2017-09-02 20:11 ` Jay Kamat
2017-09-03 8:02 ` Nicolas Goaziou [this message]
2017-09-03 16:28 ` Jay Kamat
2017-09-06 12:32 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inh0mcql.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jaygkamat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).