From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Update statistic cookies when archiving Date: Sun, 03 Sep 2017 10:02:10 +0200 Message-ID: <87inh0mcql.fsf@nicolasgoaziou.fr> References: <87r2voyi9z.fsf@gmail.com> <87mv6cyi6z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doPrH-0003aw-J8 for emacs-orgmode@gnu.org; Sun, 03 Sep 2017 04:02:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doPrD-0005e6-0K for emacs-orgmode@gnu.org; Sun, 03 Sep 2017 04:02:19 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:37714) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1doPrC-0005as-Px for emacs-orgmode@gnu.org; Sun, 03 Sep 2017 04:02:14 -0400 In-Reply-To: <87mv6cyi6z.fsf@gmail.com> (Jay Kamat's message of "Sat, 02 Sep 2017 16:11:16 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jay Kamat Cc: emacs-orgmode@gnu.org Hello, Jay Kamat writes: > Sorry, forgot to actually attach the patch, here it is. > > From 95cdfa8c3ec81b3a0763b68044611c10a4dadc29 Mon Sep 17 00:00:00 2001 > From: Jay Kamat > Date: Sat, 2 Sep 2017 15:57:36 -0400 > Subject: [PATCH] org-archive.el: Update statistic cookies when > archiving Thank you! Be warned that we're in a feature-freeze phase. It will have to wait for Org 9.1 before being merged. > + ;; Go to parent, even if no children exist Nitpick: Missing final dot. > + (org-up-heading-safe) > + ;; Update cookie of parent Ditto. > + (org-update-statistics-cookies nil))) > (message "Subtree archived %s" > (if (eq this-buffer buffer) > (concat "under heading: " heading) > @@ -470,6 +476,9 @@ Archiving time is retained in the ARCHIVE_TIME node property." > (outline-hide-subtree) > (org-cycle-show-empty-lines 'folded) > (goto-char pos))) > + (when org-provide-todo-statistics > + ;; update todo statistics of parent Ditto. Missing capital, too. > + (org-update-parent-todo-statistics)) > (org-reveal) > (if (looking-at "^[ \t]*$") > (outline-next-visible-heading 1)))) Could you provide some tests and an ORG-NEWS entry? For the latter, you can start a new "Version 9.2" top heading. Regards, -- Nicolas Goaziou