From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: stardiviner <numbchild@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Let Org Mode's completion support all Babel header arguments
Date: Tue, 12 May 2020 16:39:34 +0200 [thread overview]
Message-ID: <87imh1tdy1.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87d079s1qj.fsf@gmail.com> (stardiviner's message of "Tue, 12 May 2020 21:48:36 +0800")
Hello,
stardiviner <numbchild@gmail.com> writes:
> Subject: [PATCH] org-pcomplete.el: improve header arguments completion
Thank you. Some comments follow.
> - (while (pcomplete-here
> - '("-n" "-r" "-l"
> - ":cache" ":colnames" ":comments" ":dir" ":eval" ":exports"
> - ":file" ":hlines" ":no-expand" ":noweb" ":results" ":rownames"
> - ":session" ":shebang" ":tangle" ":tangle-mode" ":var"))))
> + (let* ((info (org-babel-get-src-block-info 'light))
> + (lang (car info))
> + (lang-headers (intern (concat "org-babel-header-args:" lang)))
> + (headers (org-babel-combine-header-arg-lists
> + org-babel-common-header-args-w-values
> + (when (boundp lang-headers) (eval lang-headers t)))))
(when ...) -> (and (bounp lang-headers)) (symbol-value lang-headers)
> + (while (pcomplete-here
> + (mapcar
> + (lambda (arg) (concat ":" (symbol-name (car arg))))
(concat ...) -> (format ":%s" (car arg))
> + headers)))))
It looks like you dropped the switches "-n", "-r", "-l".
Also, could you add a few tests in "test-org-pcomplete.el"?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-05-12 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 7:33 [RFC] Let Org Mode's completion support all Babel header arguments stardiviner
2020-05-10 12:35 ` Nicolas Goaziou
2020-05-12 13:48 ` stardiviner
2020-05-12 14:39 ` Nicolas Goaziou [this message]
2020-05-13 9:40 ` stardiviner
2020-05-13 17:04 ` Nicolas Goaziou
2020-05-14 4:05 ` stardiviner
2020-05-14 12:59 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imh1tdy1.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).