From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id fJf+Djy1ul7NTgAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 14:39:56 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4D7MI0q1ul4BLAAA1q6Kng (envelope-from ) for ; Tue, 12 May 2020 14:40:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DFF9940DB8 for ; Tue, 12 May 2020 14:40:08 +0000 (UTC) Received: from localhost ([::1]:46042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYW4m-0006Lt-T7 for larch@yhetil.org; Tue, 12 May 2020 10:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYW4K-0006J7-Bd for emacs-orgmode@gnu.org; Tue, 12 May 2020 10:39:40 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:44751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYW4I-0001zY-RR for emacs-orgmode@gnu.org; Tue, 12 May 2020 10:39:39 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 761D820000F; Tue, 12 May 2020 14:39:35 +0000 (UTC) From: Nicolas Goaziou To: stardiviner Subject: Re: [RFC] Let Org Mode's completion support all Babel header arguments References: <87mu6hsgtm.fsf@gmail.com> <87y2q0ynkq.fsf@nicolasgoaziou.fr> <87d079s1qj.fsf@gmail.com> Mail-Followup-To: stardiviner , Org Mode Date: Tue, 12 May 2020 16:39:34 +0200 In-Reply-To: <87d079s1qj.fsf@gmail.com> (stardiviner's message of "Tue, 12 May 2020 21:48:36 +0800") Message-ID: <87imh1tdy1.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 10:39:36 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53994178951144]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.06), country: US(-0.00), ip: 209.51.188.17(-0.54)]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: YjkQEBAj+0dZ Hello, stardiviner writes: > Subject: [PATCH] org-pcomplete.el: improve header arguments completion Thank you. Some comments follow. > - (while (pcomplete-here > - '("-n" "-r" "-l" > - ":cache" ":colnames" ":comments" ":dir" ":eval" ":exports" > - ":file" ":hlines" ":no-expand" ":noweb" ":results" ":rownames" > - ":session" ":shebang" ":tangle" ":tangle-mode" ":var")))) > + (let* ((info (org-babel-get-src-block-info 'light)) > + (lang (car info)) > + (lang-headers (intern (concat "org-babel-header-args:" lang))) > + (headers (org-babel-combine-header-arg-lists > + org-babel-common-header-args-w-values > + (when (boundp lang-headers) (eval lang-headers t))))) (when ...) -> (and (bounp lang-headers)) (symbol-value lang-headers) > + (while (pcomplete-here > + (mapcar > + (lambda (arg) (concat ":" (symbol-name (car arg)))) (concat ...) -> (format ":%s" (car arg)) > + headers))))) It looks like you dropped the switches "-n", "-r", "-l". Also, could you add a few tests in "test-org-pcomplete.el"? Regards, -- Nicolas Goaziou