From: James N V Cash <james.cash@occasionallycogent.com>
To: kyle@kyleam.com
Cc: bzg@gnu.org, emacs-orgmode@gnu.org
Subject: Re: eldoc recursion error
Date: Tue, 15 Sep 2020 15:22:04 -0400 [thread overview]
Message-ID: <87imcealr7.fsf@gmail.com> (raw)
In-Reply-To: 875z8lossj.fsf@kyleam.com
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
I've attached a patch that addresses the recursion issue with Emacs 28
and shows eldoc properly with example python. It presumably should act
the same with older versions of Emacs, although I haven't tested.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Org eldoc recursion patch --]
[-- Type: text/x-diff, Size: 819 bytes --]
diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el
index 3b0999340..ccc23b523 100644
--- a/contrib/lisp/org-eldoc.el
+++ b/contrib/lisp/org-eldoc.el
@@ -116,9 +116,12 @@
(when (fboundp mode-func)
(with-temp-buffer
(funcall mode-func)
- (setq doc-func (and eldoc-documentation-function
- (symbol-value 'eldoc-documentation-function)))
- (puthash lang doc-func org-eldoc-local-functions-cache))
+ (setq doc-func (if (boundp 'eldoc-documentation-functions)
+ (car eldoc-documentation-functions)
+ (and eldoc-documentation-function
+ (symbol-value 'eldoc-documentation-function))))
+
+ (puthash lang doc-func org-eldoc-local-functions-cache))
doc-func)
cached-func)))
next reply other threads:[~2020-09-16 4:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 19:22 James N V Cash [this message]
2020-09-17 4:55 ` eldoc recursion error Kyle Meyer
2020-09-17 15:03 ` James N. V. Cash
2020-09-20 4:54 ` Kyle Meyer
2020-09-20 15:35 ` James N. V. Cash
2020-09-20 15:49 ` James N. V. Cash
2020-09-20 23:38 ` Kyle Meyer
2020-09-21 1:07 ` James N. V. Cash
2020-09-21 1:36 ` Kyle Meyer
-- strict thread matches above, loose matches on Subject: below --
2020-09-08 13:49 Matt Price
2020-09-08 14:24 ` Bastien
2020-09-08 14:49 ` Matt Price
2020-09-08 14:53 ` Bastien
2020-09-08 15:27 ` Matt Price
2020-09-08 16:19 ` Matt Price
2020-09-11 4:12 ` Kyle Meyer
2020-09-21 1:51 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imcealr7.fsf@gmail.com \
--to=james.cash@occasionallycogent.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).