From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MJJPNEmWYV/QCQAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 04:36:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uLyELkmWYV/naQAAB5/wlQ (envelope-from ) for ; Wed, 16 Sep 2020 04:36:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6BEFD9404C5 for ; Wed, 16 Sep 2020 04:36:25 +0000 (UTC) Received: from localhost ([::1]:47632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIPB9-0007se-EF for larch@yhetil.org; Wed, 16 Sep 2020 00:36:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIGWn-0000YH-9v for emacs-orgmode@gnu.org; Tue, 15 Sep 2020 15:22:10 -0400 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:39601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIGWl-00032y-FK; Tue, 15 Sep 2020 15:22:08 -0400 Received: by mail-qk1-x730.google.com with SMTP id w12so5501107qki.6; Tue, 15 Sep 2020 12:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:date:message-id:mime-version; bh=cRvDZ9LHa2ro3OJi/+OlHYDqvuEQ0LfI1qDE6+8BzzY=; b=pHGS30hqoSJgVTON/f6RqE6hsUkKBEX6DEtV8DOkHyQzZ1G1ZS1ccec2Bddg8udsi6 fKNU4o5vANxQLo1jPYaMjPV1pZs60u5XyVXr2sFciaykKE9VUDJuJxHZVDw1pzC8oWpO 9bLWQAf3Jw30N97gdH6et5JJLfAcEAMj9fjktysqRTyVJeFr2NRmL4K0GHXteeOmMogj D8i50HdoQ6H0NgODwt7/Xxvl9/Yeq8zDh4YC5wUVCN9mzaJB9AE+R6kn+L0Vdeng9J8J FTHpbe7K5FuB94uxzWGGt/9xHYU9bIhEsbFwOPQ6l3kZw1ADXm9jqitJaGtkGutua3r/ m7Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=cRvDZ9LHa2ro3OJi/+OlHYDqvuEQ0LfI1qDE6+8BzzY=; b=TdGs4kUFI+LeqbxCEZhln+UK0nOoniNNOz4qcYV6rNjYbpSI+WlMnGV6H8p5kt6Rfe QhJyegpxzjG+CzwP64Y/t6fK00/FY5iykU7KaI+Eu/YXFBOKtLuOVEK+T//VuDug5PDm 0ThjEBjhJuTAO+Tz0hWAepIt3zja7SG4rCNJiYVgFb3R27I5dhi+9YZksA/qkhW2GPcE GsD93yiG5RKZazDt+us1w3Je+bIuYxXJRmCwr21ieOVe+SY6CLAxyRswcgfltQkbKcv9 8rRpNNOmhm4cIXZLBeLXKcPkcy1IokiWn0rOVI6kv6ewmdYOaZW1Rnu1haagrFg5fxM9 EAQQ== X-Gm-Message-State: AOAM531gIuQhqtkdytOg14V4m2g7SnBpZftMyq7hsXWy8CuWBnOMGrM0 Dkn+/iCbWX10VRETLgOWMyo= X-Google-Smtp-Source: ABdhPJxuEZSgRCqd5EhZuX9RC0XMuhvOvfOabgpC2QEkiQtP4yeBFSvNgbIYCGHFEPtwqz9SlKkUMg== X-Received: by 2002:ae9:d802:: with SMTP id u2mr19862150qkf.234.1600197726184; Tue, 15 Sep 2020 12:22:06 -0700 (PDT) Received: from gonk (23-233-78-78.cpe.pppoe.ca. [23.233.78.78]) by smtp.gmail.com with ESMTPSA id j6sm16744640qtn.97.2020.09.15.12.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 12:22:05 -0700 (PDT) From: James N V Cash To: kyle@kyleam.com Subject: Re: eldoc recursion error In-Reply-To: 875z8lossj.fsf@kyleam.com Date: Tue, 15 Sep 2020 15:22:04 -0400 Message-ID: <87imcealr7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=james.nvc@gmail.com; helo=mail-qk1-x730.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 16 Sep 2020 00:32:57 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bzg@gnu.org, emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=pHGS30hq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: OTtnZEPL8L1J --=-=-= Content-Type: text/plain I've attached a patch that addresses the recursion issue with Emacs 28 and shows eldoc properly with example python. It presumably should act the same with older versions of Emacs, although I haven't tested. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=org_eldoc_recursion.patch Content-Description: Org eldoc recursion patch diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el index 3b0999340..ccc23b523 100644 --- a/contrib/lisp/org-eldoc.el +++ b/contrib/lisp/org-eldoc.el @@ -116,9 +116,12 @@ (when (fboundp mode-func) (with-temp-buffer (funcall mode-func) - (setq doc-func (and eldoc-documentation-function - (symbol-value 'eldoc-documentation-function))) - (puthash lang doc-func org-eldoc-local-functions-cache)) + (setq doc-func (if (boundp 'eldoc-documentation-functions) + (car eldoc-documentation-functions) + (and eldoc-documentation-function + (symbol-value 'eldoc-documentation-function)))) + + (puthash lang doc-func org-eldoc-local-functions-cache)) doc-func) cached-func))) --=-=-=--