emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: TEC <tecosaur@gmail.com>
Cc: Bastien <bzg@gnu.org>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-plot abstractions and extension
Date: Wed, 23 Dec 2020 05:09:36 GMT	[thread overview]
Message-ID: <87im8tglbl.fsf@kyleam.com> (raw)
In-Reply-To: <87zh2hosex.fsf@bzg.fr>

Bastien writes:

> Hi Timothy,
>
> TEC <tecosaur@gmail.com> writes:
>
>> I'll attach all the patches to this email, so there's no ambiguity.
>> (crosses fingers for attachments working as expected)
>
> Applied, with minor modifications of the changelog entries:[...]

This series introduced some compiler warnings.

  $ make compile
  [...]
  In org--plot/values-stats:
  org-plot.el:199:39:Warning: ‘log10’ is an obsolete function (as of 24.4); use
      ‘log’ instead.
  
  In org--plot/nice-frequency-pick:
  org-plot.el:229:39:Warning: ‘1’ is a malformed function
  org-plot.el:229:39:Warning: ‘2’ is a malformed function
  org-plot.el:239:32:Warning: ‘t’ called as a function
  org-plot.el:525:1:Warning: Unused lexical variable ‘col-labels’
  org-plot.el:525:1:Warning: Unused lexical variable ‘deps’
  org-plot.el:525:1:Warning: Unused lexical variable ‘text-ind’
  org-plot.el:525:1:Warning: Unused lexical variable ‘ind’
  org-plot.el:525:1:Warning: Unused lexical variable ‘map’
  
  In org-plot/gnuplot:
  org-plot.el:653:56:Warning: reference to free variable ‘type-name’
  
  In end of data:
  org-plot.el:706:1:Warning: the following functions are not known to be
      defined: case, t, s-join

Most of these are minor (case -> cl-case, dropping unused bindings,
...).  The s-join one is the most important because s.el is not a
dependency.

Timothy, could you please submit a follow-up patch to address these?


  parent reply	other threads:[~2020-12-23  5:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  5:50 TEC
     [not found] ` <87blijmnv9.fsf@gnu.org>
     [not found]   ` <CAHNg_jM8sE4a6XvL5D8Gks4dQXfWhZvRBR33BDLkRgEgZ++ZGg@mail.gmail.com>
2020-09-15  3:43     ` TEC
2020-09-25 17:51       ` TEC
2020-10-17  2:12         ` TEC
2020-10-24 11:31           ` Bastien
2020-10-24 18:16             ` TEC
2020-11-21 11:49               ` ian martins
2020-12-09  2:58               ` TEC
2020-12-10 10:28                 ` Bastien
2020-12-14  5:41               ` Bastien
2020-12-14  6:30                 ` TEC
2020-12-14  6:56                   ` Bastien
2020-12-23  5:09                 ` Kyle Meyer [this message]
2020-12-23  5:10                   ` TEC
2020-12-23  6:19                     ` TEC
2020-12-23  7:14                       ` Kyle Meyer
2020-12-23  8:38                         ` TEC
2020-12-23 16:55                           ` Kyle Meyer
2020-12-23 18:19                             ` TEC
2020-12-24  3:09                               ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im8tglbl.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tecosaur@gmail.com \
    --subject='Re: [PATCH] org-plot abstractions and extension' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).