emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: TEC <tecosaur@gmail.com>
Cc: Bastien <bzg@gnu.org>, org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-plot abstractions and extension
Date: Thu, 24 Dec 2020 03:09:12 GMT	[thread overview]
Message-ID: <87eejfhpd5.fsf@kyleam.com> (raw)
In-Reply-To: <87v9cstlze.fsf@gmail.com>

TEC writes:

> Kyle Meyer <kyle@kyleam.com> writes:
>> recent org-plot example from 8d5122fc5:
>> [...]
>> That could be rewritten as [...]
> Would you like me to bundle that change in somewhere?

In my view it's fine to leave it as is (it's just an example that was
fresh in my mind), but of course feel free to send a patch for it if
you'd like.

> One question, I saw Bastien say that we didn't want whitespace-only
> commits, so how should whitespace-fixups be done?

I think the idea is to avoid whitespace-only churn, particularly if the
only goal is tab/space indentation consistency.  In that case, you'd
just leave it be unless you're changing the code for some other reason.

On the other hand, I think a dedicated patch for the indentation fix you
had in the first commit would be welcomed.  The distinction is that in
this case the code is simply misaligned:

  (mapcar (lambda (row) (org--plot/values-stats
                    (mapcar #'string-to-number (cdr row))
                    hard-max)) table)

I'd say that's worth fixing because it hurts readability.  Also, in the
process, it'd be good to move "table" to the next line because (to use
lisp-mode's phrasing) it's "hidden behind a deeper element".

> Subject: [PATCH] org-plot.el: fix compiler warnings

Thanks.  Applied (7a9a8a56a)...
> * lisp/org-plot.el (org--plot/values-stats): Replace `log10' with
> `log'.
> (org--plot/nice-frequency-pick): Replace obsolete `case' with `pcase`.

... with s/pcase/cl-case/ to match the final state of the code.

      reply	other threads:[~2020-12-24  3:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  5:50 TEC
     [not found] ` <87blijmnv9.fsf@gnu.org>
     [not found]   ` <CAHNg_jM8sE4a6XvL5D8Gks4dQXfWhZvRBR33BDLkRgEgZ++ZGg@mail.gmail.com>
2020-09-15  3:43     ` TEC
2020-09-25 17:51       ` TEC
2020-10-17  2:12         ` TEC
2020-10-24 11:31           ` Bastien
2020-10-24 18:16             ` TEC
2020-11-21 11:49               ` ian martins
2020-12-09  2:58               ` TEC
2020-12-10 10:28                 ` Bastien
2020-12-14  5:41               ` Bastien
2020-12-14  6:30                 ` TEC
2020-12-14  6:56                   ` Bastien
2020-12-23  5:09                 ` Kyle Meyer
2020-12-23  5:10                   ` TEC
2020-12-23  6:19                     ` TEC
2020-12-23  7:14                       ` Kyle Meyer
2020-12-23  8:38                         ` TEC
2020-12-23 16:55                           ` Kyle Meyer
2020-12-23 18:19                             ` TEC
2020-12-24  3:09                               ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eejfhpd5.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tecosaur@gmail.com \
    --subject='Re: [PATCH] org-plot abstractions and extension' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).