* [BUG] ox-texinfo no longer inserts menus if there is no content
@ 2023-12-14 19:57 Jonas Bernoulli
2023-12-14 20:11 ` Ihor Radchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jonas Bernoulli @ 2023-12-14 19:57 UTC (permalink / raw)
To: emacs-orgmode
Hello,
(This came up in 878r9p1ntd.fsf@bernoul.li, on emacs-devel, but it
seems it fell through the cracks.)
If a section only has subsections but no content of its own, then
ox-texinfo no longer generates the section's menu (listing the
subsections). And if the section additionally is part of an appendix,
then the subsections now use @subsection instead of @appendixsubsec.
I looked at the history of org and ox-texinfo.el in particular, but
could not find any code change that would explain that change in
behavior. Org 9.6.8 still works as expected.
---- demo.org -------------------------------------------
* only subsections, no direct content
** sub 1
body
** sub 2
body
* A
:PROPERTIES:
:APPENDIX: t
:END:
** AA only subsections, no direct content
*** AAA
body
---- demo.texi with org release_9.6.8 -------------------
\input texinfo @c -*- texinfo -*-
[...]
@node only subsections no direct content
@chapter only subsections, no direct content
@menu
* sub 1::
* sub 2::
@end menu
@node sub 1
@section sub 1
body
@node sub 2
@section sub 2
body
@node A
@appendix A
@menu
* AA only subsections, no direct content: AA only subsections no direct content.
@end menu
@node AA only subsections no direct content
@appendixsec AA only subsections, no direct content
@menu
* AAA::
@end menu
@node AAA
@appendixsubsec AAA
body
@bye
---- demo.texi with org release_9.6.13-975-gb8d27bb4e ---
\input texinfo @c -*- texinfo -*-
[...]
@node only subsections no direct content
@chapter only subsections, no direct content
@node sub 1
@section sub 1
body
@node sub 2
@section sub 2
body
@node A
@appendix A
@menu
* AA only subsections, no direct content: AA only subsections no direct content.
@end menu
@node AA only subsections no direct content
@appendixsec AA only subsections, no direct content
@node AAA
@subsection AAA
body
@bye
---------------------------------------------------------
bye;)
Jonas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [BUG] ox-texinfo no longer inserts menus if there is no content 2023-12-14 19:57 [BUG] ox-texinfo no longer inserts menus if there is no content Jonas Bernoulli @ 2023-12-14 20:11 ` Ihor Radchenko 2023-12-15 20:37 ` Jonas Bernoulli 0 siblings, 1 reply; 5+ messages in thread From: Ihor Radchenko @ 2023-12-14 20:11 UTC (permalink / raw) To: Jonas Bernoulli; +Cc: emacs-orgmode Jonas Bernoulli <jonas@bernoul.li> writes: > (This came up in 878r9p1ntd.fsf@bernoul.li, on emacs-devel, but it > seems it fell through the cracks.) I thought I fixed this in https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=dbf415b84 ... as I said in https://yhetil.org/emacs-devel/87il8sv6r2.fsf@localhost/ Are you saying that the problem is still present on the latest main? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] ox-texinfo no longer inserts menus if there is no content 2023-12-14 20:11 ` Ihor Radchenko @ 2023-12-15 20:37 ` Jonas Bernoulli 2023-12-16 14:11 ` Ihor Radchenko 0 siblings, 1 reply; 5+ messages in thread From: Jonas Bernoulli @ 2023-12-15 20:37 UTC (permalink / raw) To: Ihor Radchenko; +Cc: emacs-orgmode Ihor Radchenko <yantar92@posteo.net> writes: > Jonas Bernoulli <jonas@bernoul.li> writes: > >> (This came up in 878r9p1ntd.fsf@bernoul.li, on emacs-devel, but it >> seems it fell through the cracks.) > > I thought I fixed this in > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=dbf415b84 > > ... as I said in https://yhetil.org/emacs-devel/87il8sv6r2.fsf@localhost/ This was an unrelated bug that I found while desperately (but unsuccessfully) trying to find a possible cause of the original issue. I don't remember what the effect of this secondary (and fixed) issue was in practice; just that I noticed that this (now reverted) change, was not correct. > Are you saying that the problem is still present on the latest main? Yes, I can still reproduce the "menus are missing" and "type of subsections in appendix changed" issues with the provided test file. Cheers, Jonas ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] ox-texinfo no longer inserts menus if there is no content 2023-12-15 20:37 ` Jonas Bernoulli @ 2023-12-16 14:11 ` Ihor Radchenko 2023-12-16 16:17 ` Jonas Bernoulli 0 siblings, 1 reply; 5+ messages in thread From: Ihor Radchenko @ 2023-12-16 14:11 UTC (permalink / raw) To: Jonas Bernoulli; +Cc: emacs-orgmode Jonas Bernoulli <jonas@bernoul.li> writes: >> Are you saying that the problem is still present on the latest main? > > Yes, I can still reproduce the "menus are missing" and "type of > subsections in appendix changed" issues with the provided test file. That was a subtle bug. Fixed, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d2ce1c6ec -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] ox-texinfo no longer inserts menus if there is no content 2023-12-16 14:11 ` Ihor Radchenko @ 2023-12-16 16:17 ` Jonas Bernoulli 0 siblings, 0 replies; 5+ messages in thread From: Jonas Bernoulli @ 2023-12-16 16:17 UTC (permalink / raw) To: Ihor Radchenko; +Cc: emacs-orgmode Ihor Radchenko <yantar92@posteo.net> writes: > Jonas Bernoulli <jonas@bernoul.li> writes: > >>> Are you saying that the problem is still present on the latest main? >> >> Yes, I can still reproduce the "menus are missing" and "type of >> subsections in appendix changed" issues with the provided test file. > > That was a subtle bug. > Fixed, on main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d2ce1c6ec I can confirm. Thanks! Jonas ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-16 16:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-12-14 19:57 [BUG] ox-texinfo no longer inserts menus if there is no content Jonas Bernoulli 2023-12-14 20:11 ` Ihor Radchenko 2023-12-15 20:37 ` Jonas Bernoulli 2023-12-16 14:11 ` Ihor Radchenko 2023-12-16 16:17 ` Jonas Bernoulli
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).