emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* [PATCH] Agenda: Allow filter list without category in org-agenda-to-appt
@ 2011-10-24 19:09 Peter Münster
  2011-10-24 21:51 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Münster @ 2011-10-24 19:09 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

Here the output of "git format-patch master". I hope it's correct, it
was my first git-commit...

--8<---------------cut here---------------start------------->8---
From 82da273bb0884347762e883786b334302ad3f0cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Peter=20M=C3=BCnster?= <pmrb@free.fr>
Date: Mon, 24 Oct 2011 20:52:45 +0200
Subject: [PATCH] Agenda: Allow filter list without category in org-agenda-to-appt

* lisp/org-agenda.el (org-agenda-to-appt): Make sure filter-items are
strings before calling `string-match'.

Now it's possible to use (org-agenda-to-appt t '((headline "string"))).

TINYCHANGE
---
 lisp/org-agenda.el |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 24ead18..0b4c07b 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8489,10 +8489,12 @@ details and examples."
 		      (and (stringp filter) (string-match filter evt))
 		      (and (functionp filter) (funcall filter x))
 		      (and (listp filter)
-			   (or (string-match
-				(cadr (assoc 'category filter)) cat)
-			       (string-match
-				(cadr (assoc 'headline filter)) evt))))))
+			   (let ((cat-filter (cadr (assoc 'category filter)))
+				 (evt-filter (cadr (assoc 'headline filter))))
+			     (or (and (stringp cat-filter)
+				      (string-match cat-filter cat))
+				 (and (stringp evt-filter)
+				      (string-match evt-filter evt))))))))
 	 ;; FIXME: Shall we remove text-properties for the appt text?
 	 ;; (setq evt (set-text-properties 0 (length evt) nil evt))
 	 (when (and ok tod)
-- 
1.7.3.4
--8<---------------cut here---------------end--------------->8---

-- 
           Peter

^ permalink raw reply related	[flat|nested] 2+ messages in thread

• * Re: [PATCH] Agenda: Allow filter list without category in org-agenda-to-appt
    2011-10-24 19:09 [PATCH] Agenda: Allow filter list without category in org-agenda-to-appt Peter Münster
  @ 2011-10-24 21:51 ` Bastien
    0 siblings, 0 replies; 2+ messages in thread
  From: Bastien @ 2011-10-24 21:51 UTC (permalink / raw)
    To: Peter Münster; +Cc: emacs-orgmode
  
  Hi Peter,
  
  pmlists@free.fr (Peter Münster) writes:
  
  > Here the output of "git format-patch master". I hope it's correct, it
  > was my first git-commit...
  
  Yes, that's great -- I could save the patch and apply it 
  without problem.
  
  http://orgmode.org/w/?p=org-mode.git;a=commit;h=68ffb7a7cc8cd99a49cf69491edba85988f8229c
  
  Next time, you can simply attach the patch instead of 
  inserting it in the body of the email.  That way it gets
  caught by the patchwork.  Also, you can send it directly
  to the list, but the way to achieve this depends on your
  mail client.
  
  For example:
  
    http://andrewprice.me.uk/weblog/entry/generating-patch-emails-with-git
  
  Thanks!
  
  HTH,
  
  -- 
   Bastien
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-24 21:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-24 19:09 [PATCH] Agenda: Allow filter list without category in org-agenda-to-appt Peter Münster
2011-10-24 21:51 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).