emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <eric.schulte@gmx.com>
To: Leo Alekseyev <dnquark@gmail.com>
Cc: Emacs orgmode <emacs-orgmode@gnu.org>
Subject: Re: bug / regression: C-x C-s is broken in org-edit-special
Date: Sat, 18 Feb 2012 08:09:22 -0700	[thread overview]
Message-ID: <87hayotarz.fsf@gmx.com> (raw)
In-Reply-To: CADzxs1ndxRYXzj9GCsqQbP-LekRLjErqJZ3BnPXmiXZVQH-VRA@mail.gmail.com

Thanks for posting this workaround.

I've just pushed up a change which rebinds this key in org-src-mode.  I
don't know why the binding was ever removed in the first place.


Leo Alekseyev <dnquark@gmail.com> writes:

> In case anyone is curious, C-x C-s functionality in org-edit-special
> can be easily restored via
>   (define-key org-src-mode-map "\C-x\C-s" 'org-edit-src-save)
> On Thu, Feb 9, 2012 at 4:49 PM, Leo Alekseyev <dnquark@gmail.com> wrote:
>> Previously, C-x C-s in an org-edit-special buffer (invoked via C-')
>> would save the underlying org buffer (provided (setq
>> org-src-window-setup (quote current-window)) was set; it was buggy
>> with other settings, see
>> http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion).
>> Currently, C-x C-s prompts to save the temporary source edit buffer in
>> a new file, which is almost certainly not what the user intends.  I
>> hope someone can look into this, C-x C-s shouldn't be broken in any
>> context.
>> This broke some time between commit
>> fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week,
>> _possibly_ as a result of the change ensuring that buffer-file-name is
>> nil in temporary org-src buffers.  Buffer-file-name not being nil in a
>> temp buffer is incorrect behavior, but in this context having C-x C-s
>> not working is a much worse behavior, so perhaps that change ought to
>> be reverted if it's the culprit.
>> --Leo

Eric Schulte

      reply	other threads:[~2012-02-18 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 21:49 bug / regression: C-x C-s is broken in org-edit-special Leo Alekseyev
2012-02-13  9:54 ` Leo Alekseyev
2012-02-18 15:09   ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hayotarz.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=dnquark@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).