* bug / regression: C-x C-s is broken in org-edit-special
@ 2012-02-09 21:49 Leo Alekseyev
2012-02-13 9:54 ` Leo Alekseyev
0 siblings, 1 reply; 3+ messages in thread
From: Leo Alekseyev @ 2012-02-09 21:49 UTC (permalink / raw)
To: Emacs orgmode
Previously, C-x C-s in an org-edit-special buffer (invoked via C-')
would save the underlying org buffer (provided (setq
org-src-window-setup (quote current-window)) was set; it was buggy
with other settings, see
http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion).
Currently, C-x C-s prompts to save the temporary source edit buffer in
a new file, which is almost certainly not what the user intends. I
hope someone can look into this, C-x C-s shouldn't be broken in any
context.
This broke some time between commit
fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week,
_possibly_ as a result of the change ensuring that buffer-file-name is
nil in temporary org-src buffers. Buffer-file-name not being nil in a
temp buffer is incorrect behavior, but in this context having C-x C-s
not working is a much worse behavior, so perhaps that change ought to
be reverted if it's the culprit.
--Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug / regression: C-x C-s is broken in org-edit-special
2012-02-09 21:49 bug / regression: C-x C-s is broken in org-edit-special Leo Alekseyev
@ 2012-02-13 9:54 ` Leo Alekseyev
2012-02-18 15:09 ` Eric Schulte
0 siblings, 1 reply; 3+ messages in thread
From: Leo Alekseyev @ 2012-02-13 9:54 UTC (permalink / raw)
To: Emacs orgmode
In case anyone is curious, C-x C-s functionality in org-edit-special
can be easily restored via
(define-key org-src-mode-map "\C-x\C-s" 'org-edit-src-save)
On Thu, Feb 9, 2012 at 4:49 PM, Leo Alekseyev <dnquark@gmail.com> wrote:
> Previously, C-x C-s in an org-edit-special buffer (invoked via C-')
> would save the underlying org buffer (provided (setq
> org-src-window-setup (quote current-window)) was set; it was buggy
> with other settings, see
> http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion).
> Currently, C-x C-s prompts to save the temporary source edit buffer in
> a new file, which is almost certainly not what the user intends. I
> hope someone can look into this, C-x C-s shouldn't be broken in any
> context.
>
> This broke some time between commit
> fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week,
> _possibly_ as a result of the change ensuring that buffer-file-name is
> nil in temporary org-src buffers. Buffer-file-name not being nil in a
> temp buffer is incorrect behavior, but in this context having C-x C-s
> not working is a much worse behavior, so perhaps that change ought to
> be reverted if it's the culprit.
>
> --Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug / regression: C-x C-s is broken in org-edit-special
2012-02-13 9:54 ` Leo Alekseyev
@ 2012-02-18 15:09 ` Eric Schulte
0 siblings, 0 replies; 3+ messages in thread
From: Eric Schulte @ 2012-02-18 15:09 UTC (permalink / raw)
To: Leo Alekseyev; +Cc: Emacs orgmode
Thanks for posting this workaround.
I've just pushed up a change which rebinds this key in org-src-mode. I
don't know why the binding was ever removed in the first place.
Best,
Leo Alekseyev <dnquark@gmail.com> writes:
> In case anyone is curious, C-x C-s functionality in org-edit-special
> can be easily restored via
>
> (define-key org-src-mode-map "\C-x\C-s" 'org-edit-src-save)
>
>
> On Thu, Feb 9, 2012 at 4:49 PM, Leo Alekseyev <dnquark@gmail.com> wrote:
>> Previously, C-x C-s in an org-edit-special buffer (invoked via C-')
>> would save the underlying org buffer (provided (setq
>> org-src-window-setup (quote current-window)) was set; it was buggy
>> with other settings, see
>> http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion).
>> Currently, C-x C-s prompts to save the temporary source edit buffer in
>> a new file, which is almost certainly not what the user intends. I
>> hope someone can look into this, C-x C-s shouldn't be broken in any
>> context.
>>
>> This broke some time between commit
>> fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week,
>> _possibly_ as a result of the change ensuring that buffer-file-name is
>> nil in temporary org-src buffers. Buffer-file-name not being nil in a
>> temp buffer is incorrect behavior, but in this context having C-x C-s
>> not working is a much worse behavior, so perhaps that change ought to
>> be reverted if it's the culprit.
>>
>> --Leo
>
--
Eric Schulte
http://cs.unm.edu/~eschulte/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-18 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-09 21:49 bug / regression: C-x C-s is broken in org-edit-special Leo Alekseyev
2012-02-13 9:54 ` Leo Alekseyev
2012-02-18 15:09 ` Eric Schulte
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).