From: Achim Gratz <Stromeko@nexgo.de>
To: 10125@debbugs.gnu.org
Subject: bug#10125: RFE: require and load-path-shadowing
Date: Sun, 13 Jan 2013 08:46:59 +0100 [thread overview]
Message-ID: <87hamlbk3w.fsf@Rainer.invalid> (raw)
In-Reply-To: <81pqgh90sp.fsf@gmail.com>
Glenn Morris writes:
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125#50
>
> Turns out I was looking for invocation-directory and invocation-name.
Indeed, thanks. So using your earlier patch as a template, this should
be good for emacs-24:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 6059f03..df194b8 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -632,11 +632,20 @@ untar into a directory named DIR; otherwise, signal an error."
"Generate autoloads and do byte-compilation for package named NAME.
PKG-DIR is the name of the package directory."
(package-generate-autoloads name pkg-dir)
- (let ((load-path (cons pkg-dir load-path)))
- ;; We must load the autoloads file before byte compiling, in
- ;; case there are magic cookies to set up non-trivial paths.
- (load (expand-file-name (concat name "-autoloads") pkg-dir) nil t)
- (byte-recompile-directory pkg-dir 0 t)))
+ (with-current-buffer (get-buffer-create "*package-compile*")
+ (goto-char (point-max))
+ (pop-to-buffer (current-buffer))
+ (or (zerop (call-process
+ (concat invocation-directory invocation-name)
+ nil t t "--batch" "-Q" "--eval"
+ (format
+ "(let ((pkg-dir \"%s\")(name \"%s\"))
+ (progn (setq load-path (cons pkg-dir load-path))
+ (load (expand-file-name (concat name \"-autoloads\") pkg-dir) nil t)
+ (batch-byte-recompile-directory 0)))"
+ pkg-dir name)
+ pkg-dir))
+ (error "Compiling the package gave an error"))))
(defun package--write-file-no-coding (file-name)
(let ((buffer-file-coding-system 'no-conversion))
--8<---------------cut here---------------end--------------->8---
I've confirmed that Emacs 24.2 fails to install current Org from ELPA
without that patch when trying to install after having opened an Org
file. It installs Org correctly in that same situation with the patch
that does the package compilation in an external Emacs process.
Regards
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
next prev parent reply other threads:[~2013-01-13 7:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87sj68eogm.fsf@Rainer.invalid>
[not found] ` <mthamoy574.fsf@fencepost.gnu.org>
2013-01-11 1:57 ` bug#10125: RFE: require and load-path-shadowing Stefan Monnier
[not found] ` <jwvvcb47bs0.fsf-monnier+emacs__21035.4545656175$1357869514$gmane$org@gnu.org>
2011-11-24 12:12 ` 24.0.91; package.el (org): Macros in tar packages & order of byte compilation Jambunathan K
2002-01-01 0:33 ` bug#10125: " Jambunathan K
2011-11-24 13:05 ` Eli Zaretskii
2011-11-24 17:22 ` Jambunathan K
2011-11-24 19:09 ` Glenn Morris
[not found] ` <v062i9tk0d.fsf@fencepost.gnu.org>
2011-11-24 19:53 ` Glenn Morris
2011-11-24 22:55 ` Stelian Iancu
2011-11-24 23:54 ` Glenn Morris
2011-11-25 3:31 ` Jambunathan K
2011-11-25 12:32 ` Stelian Iancu
[not found] ` <CAKvLAojUzYmrUF_64WXEbj9zmBjzZ4gn5cDYVqLTcik41PFJ7w@mail.gmail.com>
2011-11-25 12:58 ` Jambunathan K
2011-11-25 8:10 ` Eli Zaretskii
[not found] ` <hffwhdqov3.fsf@fencepost.gnu.org>
2011-11-25 12:15 ` Jambunathan K
2011-11-25 14:07 ` Chong Yidong
[not found] ` <87r50w47o3.fsf@gnu.org>
2011-11-25 14:57 ` Stefan Monnier
2011-11-25 19:15 ` Glenn Morris
2011-11-25 19:21 ` Glenn Morris
2011-11-25 18:19 ` Glenn Morris
2011-11-25 19:01 ` Glenn Morris
[not found] ` <83vcq88vwt.fsf@gnu.org>
2011-11-25 18:20 ` Glenn Morris
2013-01-11 16:06 ` bug#10125: RFE: require and load-path-shadowing Achim Gratz
[not found] ` <jwvvcb34qjg.fsf-monnier+emacs@gnu.org>
2013-01-11 16:56 ` Stefan Monnier
2013-01-11 19:53 ` Achim Gratz
2013-01-11 22:52 ` Stefan Monnier
[not found] ` <jwvlibz2v6e.fsf-monnier+emacs@gnu.org>
2013-01-12 8:15 ` Eli Zaretskii
2013-01-12 10:15 ` Achim Gratz
2013-01-12 13:34 ` Bastien
2013-01-12 14:03 ` Stefan Monnier
2013-01-12 14:23 ` Bastien
[not found] ` <87liby7a57.fsf@bzg.ath.cx>
2013-01-12 16:12 ` Stefan Monnier
2013-01-12 17:34 ` Bastien
2013-01-12 10:20 ` Achim Gratz
2013-01-12 12:07 ` Eli Zaretskii
2013-01-12 13:28 ` Stefan Monnier
[not found] ` <jwvehhqy1k8.fsf-monnier+emacs@gnu.org>
2013-01-12 13:55 ` Eli Zaretskii
[not found] ` <83wqvisdxx.fsf__30242.1131091707$1357998993$gmane$org@gnu.org>
[not found] ` <87ip72fi8f.fsf@Rainer.invalid>
2013-01-12 18:39 ` Eli Zaretskii
2013-01-12 18:42 ` Glenn Morris
[not found] ` <71vcb22qgz.fsf__38024.2966501557$1358016217$gmane$org@fencepost.gnu.org>
[not found] ` <87hamlbk3w.fsf__41794.7558024482$1358063310$gmane$org@Rainer.invalid>
[not found] ` <87hamis0js.fsf@Rainer.invalid>
2013-01-16 9:45 ` Kevin Rodgers
[not found] ` <kd5spq$1hh$1@ger.gmane.org>
2013-01-16 10:06 ` Andreas Schwab
[not found] ` <mvmtxqh5tn0.fsf@hawking.suse.de>
2013-01-16 14:59 ` Kevin Rodgers
2013-01-12 16:29 ` Achim Gratz
2013-01-12 17:01 ` Achim Gratz
2013-01-13 7:46 ` Achim Gratz [this message]
2013-01-13 7:52 ` Achim Gratz
2013-01-15 19:34 ` Achim Gratz
2013-01-11 2:45 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hamlbk3w.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=10125@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).