emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Richard Lawrence <richard.lawrence@berkeley.edu>
To: emacs-orgmode@gnu.org
Subject: [PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export]
Date: Sun, 21 Apr 2013 12:12:39 -0700	[thread overview]
Message-ID: <87haiz1yvs.fsf_-_@berkeley.edu> (raw)
In-Reply-To: <877gjwowok.fsf@bzg.ath.cx>

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]


Here is a patch for a couple of tiny issues I encountered in ox-ascii.el
while debugging ox-icalendar.el.  Explanation:

1) There is no function called `org-ascii-footnote-definition' (though
it looks like maybe there once was?), so I changed a reference to it to
`ignore' to be more explicit.

I'm not sure if this is the right thing to do -- maybe the point was to
let the user define such a function if she wishes?  That however would
be inconsistent with the comment that such definitions are ignored (see
below).

2) A tiny change to the comment explaining why there is no such
function: footnote definitions are ignored because they are compiled by
`org-ascii-inner-template', not `org-ascii-template'.

Best,
Richard


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ox-ascii.el.patch --]
[-- Type: text/x-diff, Size: 829 bytes --]

diff --git a/lisp/ox-ascii.el b/lisp/ox-ascii.el
index 2191539..4543c34 100644
--- a/lisp/ox-ascii.el
+++ b/lisp/ox-ascii.el
@@ -68,7 +68,7 @@
     (export-block . org-ascii-export-block)
     (export-snippet . org-ascii-export-snippet)
     (fixed-width . org-ascii-fixed-width)
-    (footnote-definition . org-ascii-footnote-definition)
+    (footnote-definition . ignore)
     (footnote-reference . org-ascii-footnote-reference)
     (headline . org-ascii-headline)
     (horizontal-rule . org-ascii-horizontal-rule)
@@ -1147,7 +1147,7 @@ CONTENTS is nil.  INFO is a plist holding contextual information."
 ;;;; Footnote Definition
 
 ;; Footnote Definitions are ignored.  They are compiled at the end of
-;; the document, by `org-ascii-template'.
+;; the document, by `org-ascii-inner-template'.
 
 
 ;;;; Footnote Reference

  parent reply	other threads:[~2013-04-21 19:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20 21:14 Bug: Footnotes break iCalendar export [8.0.1 (release_8.0.1 @ /home/rwl/src/org-mode/lisp/)] Richard Lawrence
2013-04-21 13:11 ` Bastien
2013-04-21 18:52   ` Richard Lawrence
2013-04-21 19:12   ` Richard Lawrence [this message]
2013-04-21 21:53     ` [PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export] Nicolas Goaziou
2013-04-21 21:49   ` Bug: Footnotes break iCalendar export [8.0.1 (release_8.0.1 @ /home/rwl/src/org-mode/lisp/)] Nicolas Goaziou
2013-04-21 22:12     ` Bastien
2013-04-21 21:48 ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haiz1yvs.fsf_-_@berkeley.edu \
    --to=richard.lawrence@berkeley.edu \
    --cc=emacs-orgmode@gnu.org \
    --subject='[PATCH] tiny fixes in ox-ascii.el [was: Re: Bug: Footnotes break iCalendar export]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).