From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Renato Ferreira <renatofdds@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Priority #B in Agenda causes invalid face reference [8.2.1 (8.2.1-15-ge5cecc-elpa @ /Users/Paul/.emacs.d/elpa/org-20131021/)]
Date: Wed, 29 Apr 2015 23:36:04 +0200 [thread overview]
Message-ID: <87h9ryhb23.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87fv7jf8xi.fsf@gmail.com> (Renato Ferreira's message of "Wed, 29 Apr 2015 08:52:41 -0300")
Renato Ferreira <renatofdds@gmail.com> writes:
> Yes you are right, i digged deeper in the problem and it seems to be
> that the cond:
>
> (cond ((org-face-from-face-or-color
> 'priority nil
> (cdr (assoc p org-priority-faces))))
> ((and (listp org-agenda-fontify-priorities)
> (org-face-from-face-or-color
> 'priority nil
> (cdr (assoc p org-agenda-fontify-priorities)))))
> ((equal p l) 'italic)
> ((equal p h) 'bold))
>
> returns nil altogether for priorities which are neither the highest
> (equal p h) or the lowest (equal p l) (hence the bug appearing on #B
> priorities by default).
>
> That gives (nil . org-priority) so:
> (overlay-put ov 'face (nil . 'org-priority))
>
> Which triggers the message the second time it runs.
Indeed.
> From the elisp manual for (overlay-put ... 'face (a-cons . cell)):
>
> • A cons cell of the form ‘(foreground-color . COLOR-NAME)’ or
> ‘(background-color . COLOR-NAME)’. This specifies the
> foreground or background color, similar to ‘(:foreground
> COLOR-NAME)’ or ‘(:background COLOR-NAME)’. This form is
> osupported for backward compatibility only, and should be
> avoided.
Actually, the function uses the second point:
• A list of faces. Each list element should be either a face
name or an anonymous face. This specifies a face which is an
aggregate of the attributes of each of the listed faces.
Faces occurring earlier in the list have higher priority.
It should be fixed in c763faf529ef2e8f257a27df29531a4f77d633f5. Thank
you for reporting it.
Regards,
next prev parent reply other threads:[~2015-04-29 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 21:21 Bug: Priority #B in Agenda causes invalid face reference [8.2.1 (8.2.1-15-ge5cecc-elpa @ /Users/Paul/.emacs.d/elpa/org-20131021/)] Renato
2015-04-28 19:22 ` Nicolas Goaziou
2015-04-29 11:52 ` Renato Ferreira
2015-04-29 21:36 ` Nicolas Goaziou [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-10-27 8:30 Paul Rankin
2013-10-28 14:38 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9ryhb23.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=renatofdds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).