From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Priority #B in Agenda causes invalid face reference [8.2.1 (8.2.1-15-ge5cecc-elpa @ /Users/Paul/.emacs.d/elpa/org-20131021/)] Date: Wed, 29 Apr 2015 23:36:04 +0200 Message-ID: <87h9ryhb23.fsf@nicolasgoaziou.fr> References: <87fv7qv8uu.fsf@gmail.com> <87bni8kqhf.fsf@nicolasgoaziou.fr> <87fv7jf8xi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnZcx-0001RB-Fs for emacs-orgmode@gnu.org; Wed, 29 Apr 2015 17:34:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnZcw-0003b8-GQ for emacs-orgmode@gnu.org; Wed, 29 Apr 2015 17:34:43 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:54281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnZcw-0003aC-AT for emacs-orgmode@gnu.org; Wed, 29 Apr 2015 17:34:42 -0400 In-Reply-To: <87fv7jf8xi.fsf@gmail.com> (Renato Ferreira's message of "Wed, 29 Apr 2015 08:52:41 -0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Renato Ferreira Cc: emacs-orgmode@gnu.org Renato Ferreira writes: > Yes you are right, i digged deeper in the problem and it seems to be > that the cond: > > (cond ((org-face-from-face-or-color > 'priority nil > (cdr (assoc p org-priority-faces)))) > ((and (listp org-agenda-fontify-priorities) > (org-face-from-face-or-color > 'priority nil > (cdr (assoc p org-agenda-fontify-priorities))))) > ((equal p l) 'italic) > ((equal p h) 'bold)) > > returns nil altogether for priorities which are neither the highest > (equal p h) or the lowest (equal p l) (hence the bug appearing on #B > priorities by default). > > That gives (nil . org-priority) so: > (overlay-put ov 'face (nil . 'org-priority)) > > Which triggers the message the second time it runs. Indeed. > From the elisp manual for (overlay-put ... 'face (a-cons . cell)): > > =E2=80=A2 A cons cell of the form =E2=80=98(foreground-color . COLOR-NAME= )=E2=80=99 or > =E2=80=98(background-color . COLOR-NAME)=E2=80=99. This specifies the > foreground or background color, similar to =E2=80=98(:foreground > COLOR-NAME)=E2=80=99 or =E2=80=98(:background COLOR-NAME)=E2=80=99. This= form is > osupported for backward compatibility only, and should be > avoided. Actually, the function uses the second point: =E2=80=A2 A list of faces. Each list element should be either a face name or an anonymous face. This specifies a face which is an aggregate of the attributes of each of the listed faces. Faces occurring earlier in the list have higher priority. It should be fixed in c763faf529ef2e8f257a27df29531a4f77d633f5. Thank you for reporting it. Regards,