* [BUG] Failing tests for ob-clojure @ 2023-08-24 10:24 Ihor Radchenko 2023-08-24 12:26 ` Daniel Kraus 0 siblings, 1 reply; 5+ messages in thread From: Ihor Radchenko @ 2023-08-24 10:24 UTC (permalink / raw) To: emacs-orgmode, Daniel Kraus Hi, I am now going through all the babel tests that are disabled by default. ob-clojure tests appear to be completely broken: 1. (org-test-for-executable "cider") assertion is strange as cider package does not have any executable. 2. All the tests seems to assert that ob-clojure supports sessions, while it does not seem to be the case. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Failing tests for ob-clojure 2023-08-24 10:24 [BUG] Failing tests for ob-clojure Ihor Radchenko @ 2023-08-24 12:26 ` Daniel Kraus 2023-08-25 7:49 ` Ihor Radchenko 0 siblings, 1 reply; 5+ messages in thread From: Daniel Kraus @ 2023-08-24 12:26 UTC (permalink / raw) To: emacs-orgmode, Ihor Radchenko Hi! Ihor Radchenko <yantar92@posteo.net> writes: > I am now going through all the babel tests that are disabled by default. > > ob-clojure tests appear to be completely broken: > > 1. (org-test-for-executable "cider") assertion is strange as cider > package does not have any executable. > > 2. All the tests seems to assert that ob-clojure supports sessions, > while it does not seem to be the case. Unfortunately you're right and I would even say we can completely remove `test-ob-clojure.el`. There seems to be only tests for session support which currently doesn't exist anymore and another one which tests plain tangle and is not really Clojure specific. I would love to write new tests but as I just started a new job and got a new baby at the same time, I don't think I'll find the time for it the next 3-4 month :( Thanks, Daniel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Failing tests for ob-clojure 2023-08-24 12:26 ` Daniel Kraus @ 2023-08-25 7:49 ` Ihor Radchenko 2023-08-25 8:38 ` Daniel Kraus 2024-05-25 11:51 ` Ihor Radchenko 0 siblings, 2 replies; 5+ messages in thread From: Ihor Radchenko @ 2023-08-25 7:49 UTC (permalink / raw) To: Daniel Kraus; +Cc: emacs-orgmode Daniel Kraus <daniel@kraus.my> writes: > Unfortunately you're right and I would even say we can completely > remove `test-ob-clojure.el`. > There seems to be only tests for session support which currently > doesn't exist anymore and another one which tests plain tangle > and is not really Clojure specific. Done. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fcca76274 > I would love to write new tests but as I just started a new job > and got a new baby at the same time, I don't think I'll find the > time for it the next 3-4 month :( Understood. We are not in rush. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Failing tests for ob-clojure 2023-08-25 7:49 ` Ihor Radchenko @ 2023-08-25 8:38 ` Daniel Kraus 2024-05-25 11:51 ` Ihor Radchenko 1 sibling, 0 replies; 5+ messages in thread From: Daniel Kraus @ 2023-08-25 8:38 UTC (permalink / raw) To: Ihor Radchenko; +Cc: emacs-orgmode Ihor Radchenko <yantar92@posteo.net> writes: >> Unfortunately you're right and I would even say we can completely >> remove `test-ob-clojure.el`. >> There seems to be only tests for session support which currently >> doesn't exist anymore and another one which tests plain tangle >> and is not really Clojure specific. > > Done. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fcca76274 Thanks! ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BUG] Failing tests for ob-clojure 2023-08-25 7:49 ` Ihor Radchenko 2023-08-25 8:38 ` Daniel Kraus @ 2024-05-25 11:51 ` Ihor Radchenko 1 sibling, 0 replies; 5+ messages in thread From: Ihor Radchenko @ 2024-05-25 11:51 UTC (permalink / raw) To: Daniel Kraus; +Cc: emacs-orgmode Ihor Radchenko <yantar92@posteo.net> writes: >> I would love to write new tests but as I just started a new job >> and got a new baby at the same time, I don't think I'll find the >> time for it the next 3-4 month :( > > Understood. We are not in rush. It has been a while since the last activity in this thread. Daniel, have you had a chance to look into writing new tests? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-25 11:50 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-08-24 10:24 [BUG] Failing tests for ob-clojure Ihor Radchenko 2023-08-24 12:26 ` Daniel Kraus 2023-08-25 7:49 ` Ihor Radchenko 2023-08-25 8:38 ` Daniel Kraus 2024-05-25 11:51 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).