* [BUG] unfolding headlines with :extend face keyword & background broke after 2da622cad [9.7 (9.7-??-8ac99c33f @ /home/st/.config/emacs/.local/straight/build-30.0.50/org/)]
@ 2024-03-05 3:10 StrawberryTea
2024-03-05 8:04 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: StrawberryTea @ 2024-03-05 3:10 UTC (permalink / raw)
To: emacs-orgmode
Hi, using the following test case with Emacs -Q:
(let ((default-directory (file-name-directory load-file-name)))
(when (file-exists-p (expand-file-name "default.el" default-directory))
(load-file (expand-file-name "default.el" default-directory))))
(straight-use-package 'org)
(require 'org)
(load-theme 'leuven t)
(dolist (face '(org-level-1 org-level-2 org-level-3 org-level-4 org-level-5
org-level-6 org-level-7 org-level-8))
(set-face-attribute face nil :extend t))
(setq org-fontify-whole-heading-line t)
(setq org-startup-folded t)
(defvar org-extend-faces-bug-4-file "/tmp/org-extend-faces-bug-4.org"
"The file to be used for the bug demo.")
(with-temp-buffer
(insert "* foo\n** bar\ntest\n** baz\ntest")
(write-file org-extend-faces-bug-4-file))
(find-file org-extend-faces-bug-4-file)
The most recent fix for the bug in 2da622cad seems to have made things
worse. Now sometimes the background of the headline is not extended and
other times we still have the trailing background color where it's not
supposed to. It's definitely a lot worse when the file is started up
folded because the issue seems to be specifically related with unfolding
a heading with subheadings.
StrawberryTea <
Emacs : GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0)
of 2024-03-04
Package: Org mode version 9.7 (9.7-??-8ac99c33f @ /home/st/.config/emacs/.local/straight/build-30.0.50/org/)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] unfolding headlines with :extend face keyword & background broke after 2da622cad [9.7 (9.7-??-8ac99c33f @ /home/st/.config/emacs/.local/straight/build-30.0.50/org/)]
2024-03-05 3:10 [BUG] unfolding headlines with :extend face keyword & background broke after 2da622cad [9.7 (9.7-??-8ac99c33f @ /home/st/.config/emacs/.local/straight/build-30.0.50/org/)] StrawberryTea
@ 2024-03-05 8:04 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-03-05 8:04 UTC (permalink / raw)
To: StrawberryTea; +Cc: emacs-orgmode
StrawberryTea <look@strawberrytea.xyz> writes:
> Hi, using the following test case with Emacs -Q:
> ...
> The most recent fix for the bug in 2da622cad seems to have made things
> worse. Now sometimes the background of the headline is not extended and
> other times we still have the trailing background color where it's not
> supposed to. It's definitely a lot worse when the file is started up
> folded because the issue seems to be specifically related with unfolding
> a heading with subheadings.
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1151c614b
Maybe I even did not break the other cases :)
(We may need proper tests for this feature)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-05 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-05 3:10 [BUG] unfolding headlines with :extend face keyword & background broke after 2da622cad [9.7 (9.7-??-8ac99c33f @ /home/st/.config/emacs/.local/straight/build-30.0.50/org/)] StrawberryTea
2024-03-05 8:04 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).