emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Michael Sperber <sperber@deinprogramm.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Current patches to make org-mode run on XEmacs
Date: Wed, 31 Aug 2011 20:25:46 +0200	[thread overview]
Message-ID: <87fwkhh1zp.fsf@gmail.com> (raw)
In-Reply-To: <y9lmxep1mdl.fsf@deinprogramm.de> (Michael Sperber's message of "Wed, 31 Aug 2011 20:12:06 +0200")

Hello,

Michael Sperber <sperber@deinprogramm.de> writes:

> ... are attached.  I've run with this for a few weeks now, and what I
> use mostly works.  So I would appreciate if these could go into the git
> repo.
>
> Let me draw your attention to this hunk:
>
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7360,7 +7360,7 @@ would end up with no indentation after the change, nothing at all is done."
>  	   col)
>        (while (re-search-forward
>  	      (concat "\\(" (regexp-opt org-all-time-keywords)
> -		      "\\|" "^[ \t]*" org-tsr-regexp-both "*$"
> +		      "\\|" "^[ \t]*" org-tsr-regexp-both "$"
>  		      "\\|" "^[ \t]*:[a-zA-Z][a-zA-Z0-9_]*:.*$"
>  		      "\\)") (or drawer-end end) t)
>  	(beginning-of-line)
>
> While I needed this to make the code run on XEmacs, it really looks like
> a bug fix to me: The "*" that I deleted makes that part of the
> disjunction match the empty string

I don't think so, as `org-tsr-regexp-both' isn't made up of one big
group. But that star is strange indeed.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2011-08-31 18:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 18:12 Current patches to make org-mode run on XEmacs Michael Sperber
2011-08-31 18:25 ` Nicolas Goaziou [this message]
2011-10-21 18:36 ` Bastien
2011-10-21 19:06   ` Sebastien Vauban
2011-10-21 21:32 ` Carsten Dominik
2011-10-22 12:56   ` Bastien
2011-10-22 13:03   ` Michael Sperber
2011-10-22 13:34     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwkhh1zp.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sperber@deinprogramm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).