From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Current patches to make org-mode run on XEmacs Date: Wed, 31 Aug 2011 20:25:46 +0200 Message-ID: <87fwkhh1zp.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:38013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QypUZ-0000DW-2p for emacs-orgmode@gnu.org; Wed, 31 Aug 2011 14:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QypUX-0001DE-Pp for emacs-orgmode@gnu.org; Wed, 31 Aug 2011 14:26:27 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:61267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QypUX-0001D6-JV for emacs-orgmode@gnu.org; Wed, 31 Aug 2011 14:26:25 -0400 Received: by wwf10 with SMTP id 10so887940wwf.30 for ; Wed, 31 Aug 2011 11:26:24 -0700 (PDT) In-Reply-To: (Michael Sperber's message of "Wed, 31 Aug 2011 20:12:06 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Sperber Cc: emacs-orgmode@gnu.org Hello, Michael Sperber writes: > ... are attached. I've run with this for a few weeks now, and what I > use mostly works. So I would appreciate if these could go into the git > repo. > > Let me draw your attention to this hunk: > > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -7360,7 +7360,7 @@ would end up with no indentation after the change, nothing at all is done." > col) > (while (re-search-forward > (concat "\\(" (regexp-opt org-all-time-keywords) > - "\\|" "^[ \t]*" org-tsr-regexp-both "*$" > + "\\|" "^[ \t]*" org-tsr-regexp-both "$" > "\\|" "^[ \t]*:[a-zA-Z][a-zA-Z0-9_]*:.*$" > "\\)") (or drawer-end end) t) > (beginning-of-line) > > While I needed this to make the code run on XEmacs, it really looks like > a bug fix to me: The "*" that I deleted makes that part of the > disjunction match the empty string I don't think so, as `org-tsr-regexp-both' isn't made up of one big group. But that star is strange indeed. Regards, -- Nicolas Goaziou