emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Patch: org-mac-iCal is a no-op on OS X 10.8
@ 2012-12-01 14:11 Steve Purcell
  2012-12-04 14:16 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Purcell @ 2012-12-01 14:11 UTC (permalink / raw)
  To: emacs-orgmode

I just found that org-mac-iCal.el doesn't work on OS X 10.8 (Mountain
Lion).

The trivial patch below fixes this.

Cheers,

-Steve


commit 71b50131b5e6ae00a5e6c2f0bff2cec377c68c0f (HEAD, refs/heads/master)
Author: Steve Purcell <steve@sanityinc.com>
Date:   Sat Dec 1 14:06:02 2012 +0000

    org-mac-iCal: also use post-Leopard logic to concatenate calendars in 10.8

	Modified   contrib/lisp/org-mac-iCal.el
diff --git a/contrib/lisp/org-mac-iCal.el b/contrib/lisp/org-mac-iCal.el
index 0fdc95f..a48cf22 100644
--- a/contrib/lisp/org-mac-iCal.el
+++ b/contrib/lisp/org-mac-iCal.el
@@ -99,7 +99,7 @@ the the Emacs diary"
   ;; for each calendar, concatenate individual events into a single ics file
   (with-temp-buffer
     (shell-command "sw_vers" (current-buffer))
-    (when (re-search-backward "10\\.[567]" nil t)
+    (when (re-search-backward "10\\.[5678]" nil t)
       (omi-concat-leopard-ics all-calendars)))
 
   ;; move all caldav ics files to the same place as local ics files

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Patch: org-mac-iCal is a no-op on OS X 10.8
  2012-12-01 14:11 Patch: org-mac-iCal is a no-op on OS X 10.8 Steve Purcell
@ 2012-12-04 14:16 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-12-04 14:16 UTC (permalink / raw)
  To: Steve Purcell; +Cc: emacs-orgmode

Hi Steve,

Steve Purcell <steve@sanityinc.com> writes:

> I just found that org-mac-iCal.el doesn't work on OS X 10.8 (Mountain
> Lion).
>
> The trivial patch below fixes this.

Applied, thanks.

For the next patch, please a full changelog with the TINYCHANGE 
cookie, it helps us to provide a correct changelog back into Emacs
when we merge Org in the Emacs trunk.

See http://orgmode.org/worg/org-contribute.html#sec-5 for details.

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-04 14:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-01 14:11 Patch: org-mac-iCal is a no-op on OS X 10.8 Steve Purcell
2012-12-04 14:16 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).