From: Christian Egli <christian.egli@sbs.ch>
To: emacs-orgmode@gnu.org
Subject: Re: ox-taskjuggler : Correct a small typo and deal with Scheduled and deadline in task
Date: Sun, 21 Apr 2013 22:20:29 +0200 [thread overview]
Message-ID: <87fvyjzlde.fsf@sbs.ch> (raw)
In-Reply-To: 874nf24g0n.fsf@bat.fr.eu.org
Hi Baptiste
Thanks for the patch. It fixes a pretty bad oversight that you currently
apparently cannot define a start and an end using SCHEDULED and DEADLINE
(I thought this worked in the old exporter and was maybe lost in the
translation). I would like to use the patch but there are a couple of
issues:
Baptiste <bateast@bat.fr.eu.org> writes:
> (effort (org-element-property :EFFORT task))
> + (start (org-taskjuggler-get-start task))
> + (end (org-taskjuggler-get-end task))
This is obviously OK.
> @@ -775,6 +777,14 @@ a unique id will be associated to it."
> (org-taskjuggler-get-id task info)
> (org-taskjuggler-get-name task))
> ;; Add default attributes.
> + (and milestone
> + (cond
> + ((and start end) (format " start %s\n maxend %s\n" start end))
Are you saying that if we have a milestone, a start and an end date we
should define the start and use the end date as a maxend? This seems
like an interesting approach. Unfortunately currently `milestone' is
true only if there is not both and start and an end date. We should
probably also change the definition of milestone (see
http://orgmode.org/cgit.cgi/org-mode.git/tree/contrib/lisp/ox-taskjuggler.el#n757).
> + ((and start) (format " start %s\n" start))
This looks a bit fishy. Shouldn't this be
((start) (format " start %s\n" start))
> + ((and end) (format " start %s\n" end))))
Ditto
Also we should probably change the definition of
`org-taskjuggler-get-start' to also look for a "start" attribute but
that's another story.
Can you fix these issues and resend?
Thanks
Christian
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
next prev parent reply other threads:[~2013-04-21 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 16:55 ox-taskjuggler : Correct a small typo and deal with Scheduled and deadline in task Baptiste
2013-04-20 7:21 ` Bastien
2013-04-21 20:20 ` Christian Egli [this message]
2013-04-21 22:13 ` Bastien
2013-04-22 7:42 ` Christian Egli
2013-04-22 9:20 ` Baptiste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvyjzlde.fsf@sbs.ch \
--to=christian.egli@sbs.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).