From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Egli Subject: Re: ox-taskjuggler : Correct a small typo and deal with Scheduled and deadline in task Date: Sun, 21 Apr 2013 22:20:29 +0200 Message-ID: <87fvyjzlde.fsf@sbs.ch> References: <874nf24g0n.fsf@bat.fr.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:49149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UU0kf-0005zH-KP for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 16:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UU0kd-0007EU-On for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 16:20:45 -0400 Received: from plane.gmane.org ([80.91.229.3]:57464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UU0kd-0007EN-H8 for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 16:20:43 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UU0kc-0006cI-8R for emacs-orgmode@gnu.org; Sun, 21 Apr 2013 22:20:42 +0200 Received: from alouette.sbs.ch ([194.29.12.218]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 21 Apr 2013 22:20:41 +0200 Received: from christian.egli by alouette.sbs.ch with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 21 Apr 2013 22:20:41 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Baptiste Thanks for the patch. It fixes a pretty bad oversight that you currently apparently cannot define a start and an end using SCHEDULED and DEADLINE (I thought this worked in the old exporter and was maybe lost in the translation). I would like to use the patch but there are a couple of issues: Baptiste writes: > (effort (org-element-property :EFFORT task)) > + (start (org-taskjuggler-get-start task)) > + (end (org-taskjuggler-get-end task)) This is obviously OK. > @@ -775,6 +777,14 @@ a unique id will be associated to it." > (org-taskjuggler-get-id task info) > (org-taskjuggler-get-name task)) > ;; Add default attributes. > + (and milestone > + (cond > + ((and start end) (format " start %s\n maxend %s\n" start end)) Are you saying that if we have a milestone, a start and an end date we should define the start and use the end date as a maxend? This seems like an interesting approach. Unfortunately currently `milestone' is true only if there is not both and start and an end date. We should probably also change the definition of milestone (see http://orgmode.org/cgit.cgi/org-mode.git/tree/contrib/lisp/ox-taskjuggler.el#n757). > + ((and start) (format " start %s\n" start)) This looks a bit fishy. Shouldn't this be ((start) (format " start %s\n" start)) > + ((and end) (format " start %s\n" end)))) Ditto Also we should probably change the definition of `org-taskjuggler-get-start' to also look for a "start" attribute but that's another story. Can you fix these issues and resend? Thanks Christian -- Christian Egli Swiss Library for the Blind, Visually Impaired and Print Disabled Grubenstrasse 12, CH-8045 Zürich, Switzerland