emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Benjamin Drieu <bdrieu@april.org>
To: emacs-orgmode@gnu.org
Subject: Bug: If multiple org-store-link-function available, Org fails to prompt which [8.2.5g (8.2.5g-dist @ /home/benj/usr/share/emacs/site-lisp/org/)]
Date: Wed, 29 Jan 2014 11:46:40 +0100	[thread overview]
Message-ID: <87fvo7xdyn.fsf@dedam.april.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]


Since probably version 8.2 of Org I could not store links from Gnus.
After some investigation it appears that org-store-link was faulty, not
allowing me to choose between functions.  The cause is that
completing-read was not called properly, attached patch (hopefully)
fixes this.

Bug is trigged only if multiple store link functions are available,
which was my case since I included org-nnml.el as well as org-gnus.el.


Emacs  : GNU Emacs 23.4.1 (i486-pc-linux-gnu, GTK+ Version 2.24.10)
 of 2012-09-09 on murphy, modified by Debian
Package: Org-mode version 8.2.5g (8.2.5g-dist @ /home/benj/usr/share/emacs/site-lisp/org/)

-- 
* Benjamin Drieu <bdrieu@april.org> - http://www.april.org/
* Soutenez le logiciel libre, rejoignez l'April
  http://www.april.org/association/adhesion.html

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1: org-store-link.patch --]
[-- Type: text/x-diff, Size: 424 bytes --]

--- org-orig.el	2014-01-29 11:43:43.000000000 +0100
+++ org.el	2014-01-29 11:39:37.000000000 +0100
@@ -9411,7 +9411,7 @@
 		       (funcall (intern
 				 (completing-read
 				  "Which function for creating the link? "
-				  sfunsn t (car sfunsn)))))
+				  sfunsn nil t (car sfunsn)))))
 		  (funcall (caar sfuns)))
 	      (setq link (plist-get org-store-link-plist :link)
 		    desc (or (plist-get org-store-link-plist

[-- Attachment #2.2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2014-01-29 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 10:46 Benjamin Drieu [this message]
2014-01-29 13:58 ` Bug: If multiple org-store-link-function available, Org fails to prompt which [8.2.5g (8.2.5g-dist @ /home/benj/usr/share/emacs/site-lisp/org/)] Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvo7xdyn.fsf@dedam.april.org \
    --to=bdrieu@april.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).