From mboxrd@z Thu Jan  1 00:00:00 1970
From: Benjamin Drieu <bdrieu@april.org>
Subject: Bug: If multiple org-store-link-function available, Org fails to
 prompt which [8.2.5g (8.2.5g-dist @
 /home/benj/usr/share/emacs/site-lisp/org/)]
Date: Wed, 29 Jan 2014 11:46:40 +0100
Message-ID: <87fvo7xdyn.fsf@dedam.april.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bdrieu@april.org>) id 1W8SgH-0002wC-0R
	for emacs-orgmode@gnu.org; Wed, 29 Jan 2014 05:47:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bdrieu@april.org>) id 1W8SgA-0007H9-RP
	for emacs-orgmode@gnu.org; Wed, 29 Jan 2014 05:47:40 -0500
Received: from taverne.drieu.org ([176.31.119.197]:43485)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bdrieu@april.org>) id 1W8SgA-0007Gu-Kw
	for emacs-orgmode@gnu.org; Wed, 29 Jan 2014 05:47:34 -0500
Received: from dedam.april.org (home.drieu.org [82.227.148.7])
	by taverne.drieu.org (Postfix) with ESMTPS id 05544E6E9C
	for <emacs-orgmode@gnu.org>; Wed, 29 Jan 2014 11:46:44 +0100 (CET)
Received: from benj by dedam.april.org with local (Exim 4.80)
	(envelope-from <bdrieu@april.org>) id 1W8SfK-00029C-LP
	for emacs-orgmode@gnu.org; Wed, 29 Jan 2014 11:46:42 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

--=-=-=


Since probably version 8.2 of Org I could not store links from Gnus.
After some investigation it appears that org-store-link was faulty, not
allowing me to choose between functions.  The cause is that
completing-read was not called properly, attached patch (hopefully)
fixes this.

Bug is trigged only if multiple store link functions are available,
which was my case since I included org-nnml.el as well as org-gnus.el.


Emacs  : GNU Emacs 23.4.1 (i486-pc-linux-gnu, GTK+ Version 2.24.10)
 of 2012-09-09 on murphy, modified by Debian
Package: Org-mode version 8.2.5g (8.2.5g-dist @ /home/benj/usr/share/emacs/site-lisp/org/)

-- 
* Benjamin Drieu <bdrieu@april.org> - http://www.april.org/
* Soutenez le logiciel libre, rejoignez l'April
  http://www.april.org/association/adhesion.html

--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=org-store-link.patch

--- org-orig.el	2014-01-29 11:43:43.000000000 +0100
+++ org.el	2014-01-29 11:39:37.000000000 +0100
@@ -9411,7 +9411,7 @@
 		       (funcall (intern
 				 (completing-read
 				  "Which function for creating the link? "
-				  sfunsn t (car sfunsn)))))
+				  sfunsn nil t (car sfunsn)))))
 		  (funcall (caar sfuns)))
 	      (setq link (plist-get org-store-link-plist :link)
 		    desc (or (plist-get org-store-link-plist

--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFS6NwQnDLqtZBL50ERAkhTAKD7no3XcjQTKRF9NmMRpdRjMBOUkgCfWwUb
+mDkcVBYdXt1vh4Xrc8aAXk=
=HLtk
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--