From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Christian Egli <christian.egli@sbs.ch>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] ox-taskjuggler: unable to use depends {gapduration}
Date: Wed, 05 Nov 2014 14:27:36 +0100 [thread overview]
Message-ID: <87fvdx93qv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871tpiys4f.fsf@sbs.ch> (Christian Egli's message of "Wed, 05 Nov 2014 09:21:52 +0100")
Hello,
Christian Egli <christian.egli@sbs.ch> writes:
> No it is indeed a bug. At first I thought this was simply no longer
> working in the new exporter but I was wrong. Nicolas of course
> implemented it and way more. But there is a subtle bug. I actually found
> it because I wondered about the funny "t :taskjuggl" in the output.
> Here's the fix.
>
> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
> index 807d702..9e977f6 100644
> --- a/contrib/lisp/ox-taskjuggler.el
> +++ b/contrib/lisp/ox-taskjuggler.el
> @@ -600,7 +600,7 @@ doesn't include leading \"depends\"."
> (let ((id (org-element-property :TASK_ID dep)))
> (and id
> (string-match (concat id " +\\({.*?}\\)") dep-str)
> - (org-match-string-no-properties 1))))
> + (org-match-string-no-properties 1 dep-str))))
> path)
> ;; Compute number of exclamation marks by looking for the
> ;; common ancestor between TASK and DEP.
>
> Nicolas, I can push this myself but I haven't pushed to the repo in
> years. What is the current way? Do I just push to master?
I think you should push to maint, so that users of org+contrib package
can benefit from your fix soon enough. You then need to merge maint
into master.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-11-05 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 6:39 [BUG] ox-taskjuggler: unable to use depends {gapduration} John Hendy
2014-11-05 8:21 ` Christian Egli
2014-11-05 13:27 ` Nicolas Goaziou [this message]
2014-11-06 8:19 ` Christian Egli
2014-11-06 17:33 ` Nicolas Goaziou
2014-11-06 0:41 ` John Hendy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvdx93qv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=christian.egli@sbs.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).