From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG] ox-taskjuggler: unable to use depends {gapduration} Date: Wed, 05 Nov 2014 14:27:36 +0100 Message-ID: <87fvdx93qv.fsf@nicolasgoaziou.fr> References: <871tpiys4f.fsf@sbs.ch> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm0bx-0005ZK-AY for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 08:27:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm0bm-00009N-BX for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 08:26:57 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:47207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm0bm-00007k-57 for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 08:26:46 -0500 In-Reply-To: <871tpiys4f.fsf@sbs.ch> (Christian Egli's message of "Wed, 05 Nov 2014 09:21:52 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Christian Egli Cc: emacs-orgmode@gnu.org Hello, Christian Egli writes: > No it is indeed a bug. At first I thought this was simply no longer > working in the new exporter but I was wrong. Nicolas of course > implemented it and way more. But there is a subtle bug. I actually found > it because I wondered about the funny "t :taskjuggl" in the output. > Here's the fix. > > diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el > index 807d702..9e977f6 100644 > --- a/contrib/lisp/ox-taskjuggler.el > +++ b/contrib/lisp/ox-taskjuggler.el > @@ -600,7 +600,7 @@ doesn't include leading \"depends\"." > (let ((id (org-element-property :TASK_ID dep))) > (and id > (string-match (concat id " +\\({.*?}\\)") dep-str) > - (org-match-string-no-properties 1)))) > + (org-match-string-no-properties 1 dep-str)))) > path) > ;; Compute number of exclamation marks by looking for the > ;; common ancestor between TASK and DEP. > > Nicolas, I can push this myself but I haven't pushed to the repo in > years. What is the current way? Do I just push to master? I think you should push to maint, so that users of org+contrib package can benefit from your fix soon enough. You then need to merge maint into master. Regards, -- Nicolas Goaziou