emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Bram Adams <bram.adams@polymtl.ca>
Cc: emacs-orgmode@gnu.org, Ihor Radchenko <yantar92@gmail.com>
Subject: Re: Bug (with fix): org-tempo-add-block incorrectly inserts comma before next `#+begin_src' during expansion [9.3.2 (9.3.2-8-g47b104-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20200127/)]
Date: Mon, 03 Feb 2020 18:33:10 +0100	[thread overview]
Message-ID: <87ftfrd19l.fsf@bzg.fr> (raw)
In-Reply-To: <DC91A0A4-5F85-44DC-BBD6-66C88D83E8E0@polymtl.ca>

Hi Bram,

Bram Adams <bram.adams@polymtl.ca> writes:

> I applied the commit, but still encounter the same issue, unless I
> disable `org-src-tab-acts-natively’ or remove ‘> in the org-tempo
> macro.

Yes, you're right, my fix was wrong - I've followed your indication
and removed the second occurrence of '>.

What happens is this: the template expansion calls org-edit-src-code
which gets the wrong source block boundaries, thus escaping "#+begin"
with a comma.

Looking at the second '>, I think there is no need for it here (it
means: "indent the line"), so we're safe removing it without touching
`org-edit-src-code' for now.

I still think org-edit-src-code should only be called interactively,
not through internal calls.  I'll see if this needs to be fixed too.

Best,

-- 
 Bastien

  reply	other threads:[~2020-02-03 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02  4:15 Bram Adams
2020-02-03  3:38 ` Ihor Radchenko
2020-02-03  4:35   ` Bram Adams
2020-02-03 12:13     ` Bastien
2020-02-03 15:08       ` Bram Adams
2020-02-03 15:45         ` Bastien
2020-02-03 16:23           ` Bram Adams
2020-02-03 17:33             ` Bastien [this message]
2020-02-03 18:18               ` Bram Adams
2020-04-08 15:50       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftfrd19l.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=bram.adams@polymtl.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --subject='Re: Bug (with fix): org-tempo-add-block incorrectly inserts comma before next `#+begin_src'\'' during expansion [9.3.2 (9.3.2-8-g47b104-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20200127/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).