From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Bug (with fix): org-tempo-add-block incorrectly inserts comma before next `#+begin_src' during expansion [9.3.2 (9.3.2-8-g47b104-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20200127/)] Date: Mon, 03 Feb 2020 18:33:10 +0100 Message-ID: <87ftfrd19l.fsf@bzg.fr> References: <93C72314-096C-4C7A-83B6-D96F581E92D5@polymtl.ca> <87a7608hn1.fsf@localhost> <87wo93j2c5.fsf@gnu.org> <70260249-4E4A-49A0-B305-A6768A7CB54F@polymtl.ca> <87zhdzk73c.fsf@bzg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56471) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyfb0-0006rL-VY for emacs-orgmode@gnu.org; Mon, 03 Feb 2020 12:33:15 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bram Adams Cc: emacs-orgmode@gnu.org, Ihor Radchenko Hi Bram, Bram Adams writes: > I applied the commit, but still encounter the same issue, unless I > disable `org-src-tab-acts-natively=E2=80=99 or remove =E2=80=98> in the o= rg-tempo > macro. Yes, you're right, my fix was wrong - I've followed your indication and removed the second occurrence of '>. What happens is this: the template expansion calls org-edit-src-code which gets the wrong source block boundaries, thus escaping "#+begin" with a comma. Looking at the second '>, I think there is no need for it here (it means: "indent the line"), so we're safe removing it without touching `org-edit-src-code' for now. I still think org-edit-src-code should only be called interactively, not through internal calls. I'll see if this needs to be fixed too. Best, --=20 Bastien