* [PATCH] testing: Delete useless ert tests
@ 2023-09-16 19:50 Ilya Chernyshov
2023-09-17 9:49 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Chernyshov @ 2023-09-16 19:50 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Hi!
I applied my ert test deduplicator on org tests and found some useless tests
which you can see in the patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-testing-Delete-useless-ert-tests.patch --]
[-- Type: text/x-patch, Size: 2501 bytes --]
From 32d83fc5b2ad076dcd8681434a46b4117ac23858 Mon Sep 17 00:00:00 2001
From: Ilya Chernyshov <ichernyshovvv@gmail.com>
Date: Sun, 17 Sep 2023 02:33:51 +0700
Subject: [PATCH] testing: Delete useless ert tests
* testing/lisp/test-ob-C.el: Delete useless test.
* testing/lisp/test-ob-fortran.el: Delete useless test.
* testing/lisp/test-ob-lilypond.el: Delete useless test.
* testing/lisp/test-ob-maxima.el: Delete useless test.
---
testing/lisp/test-ob-C.el | 3 ---
testing/lisp/test-ob-fortran.el | 3 ---
testing/lisp/test-ob-lilypond.el | 3 ---
testing/lisp/test-ob-maxima.el | 3 ---
4 files changed, 12 deletions(-)
diff --git a/testing/lisp/test-ob-C.el b/testing/lisp/test-ob-C.el
index 8546a48dd..c70534a51 100644
--- a/testing/lisp/test-ob-C.el
+++ b/testing/lisp/test-ob-C.el
@@ -22,9 +22,6 @@
(unless (featurep 'ob-C)
(signal 'missing-test-dependency "Support for C code blocks"))
-(ert-deftest ob-C/assert ()
- (should t))
-
(ert-deftest ob-C/simple-program ()
"Hello world program."
(if (executable-find org-babel-C++-compiler)
diff --git a/testing/lisp/test-ob-fortran.el b/testing/lisp/test-ob-fortran.el
index 3bff7b9c4..4947d142b 100644
--- a/testing/lisp/test-ob-fortran.el
+++ b/testing/lisp/test-ob-fortran.el
@@ -23,9 +23,6 @@
(unless (featurep 'ob-fortran)
(signal 'missing-test-dependency "Support for Fortran code blocks"))
-(ert-deftest ob-fortran/assert ()
- (should t))
-
(ert-deftest ob-fortran/simple-program ()
"Test of hello world program."
(org-test-at-id "459384e8-1797-4f11-867e-dde0473ea7cc"
diff --git a/testing/lisp/test-ob-lilypond.el b/testing/lisp/test-ob-lilypond.el
index 5f439793b..49a61fcab 100644
--- a/testing/lisp/test-ob-lilypond.el
+++ b/testing/lisp/test-ob-lilypond.el
@@ -26,9 +26,6 @@
(file-name-directory
(or load-file-name (buffer-file-name)))))
-(ert-deftest ob-lilypond/assert ()
- (should t))
-
(ert-deftest ob-lilypond/feature-provision ()
(should (featurep 'ob-lilypond)))
diff --git a/testing/lisp/test-ob-maxima.el b/testing/lisp/test-ob-maxima.el
index e2433d232..ae9fdc775 100644
--- a/testing/lisp/test-ob-maxima.el
+++ b/testing/lisp/test-ob-maxima.el
@@ -22,9 +22,6 @@
(unless (featurep 'ob-maxima)
(signal 'missing-test-dependency "Support for Maxima code blocks"))
-(ert-deftest ob-maxima/assert ()
- (should t))
-
(ert-deftest ob-maxima/integer-input ()
"Test of integer input"
(org-test-at-id "b5842ed4-8e8b-4b18-a1c9-cef006b6a6c8"
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] testing: Delete useless ert tests
2023-09-16 19:50 [PATCH] testing: Delete useless ert tests Ilya Chernyshov
@ 2023-09-17 9:49 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2023-09-17 9:49 UTC (permalink / raw)
To: Ilya Chernyshov; +Cc: emacs-orgmode
Ilya Chernyshov <ichernyshovvv@gmail.com> writes:
> I applied my ert test deduplicator on org tests and found some useless tests
> which you can see in the patch.
> ...
> -(ert-deftest ob-C/assert ()
> - (should t))
Thanks!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e203b5a65
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-17 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-16 19:50 [PATCH] testing: Delete useless ert tests Ilya Chernyshov
2023-09-17 9:49 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).