emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix agenda display for late scheduled and deadline tasks
Date: Mon, 21 Jun 2010 08:51:24 -0400	[thread overview]
Message-ID: <87eig05z1v.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <87aaqoimgc.fsf@fastmail.fm> (Matt Lundin's message of "Mon\, 21 Jun 2010 08\:45\:07 -0400")

Matt Lundin <mdl@imapmail.org> writes:

> Hi Bernt,
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> * lisp/org-agenda.el (org-agenda-get-deadlines):
>> (org-agenda-get-scheduled):
>> * lisp/org.el (org-time-string-to-seconds):
>> For deadline and scheduled agenda display ignore the cyclic repeater
>> when calculating how many days late the task is.  If you have a weekly
>> task and miss the date the agenda view will show more than a week late
>> now instead of resetting on the cyclic repeating date.  This makes it
>> much more obvious when you missed a repeating task after the repeater.
>> ---
>> Updated patch - fixes DAYN -> DAYNR in the docstring.
>
> I believe this patch breaks the functionality of
> org-agenda-repeating-timestamp-show-all.
>
> I have org-agenda-repeating-timestamp-show-all set to t, but only one
> occurrence of each repeating timestamp is shown.

Hi Matt,

Sorry about that.  I don't use org-agenda-repeating-timestamp-show-all.

I guess we have two options

 1) revert the patch
 2) continue with the old behaviour if this variable is set.

I'm not sure what is best here -- if we go with option 2) then the
agenda display for scheduled and deadline tasks changes based on this
variable which may not be obvious.

I'll try to post a patch for option 2) later today.

Thanks for the feedback.

Regards,
Bernt

next prev parent reply	other threads:[~2010-06-21 12:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12 16:09 [PATCH] Fix agenda display for late scheduled and deadline tasks Bernt Hansen
2010-06-12 16:13 ` Bernt Hansen
2010-06-16 14:16   ` Bastien
2010-06-21 12:45   ` Matt Lundin
2010-06-21 12:51     ` Bernt Hansen [this message]
2010-06-21 13:02       ` Bernt Hansen
2010-06-21 13:06         ` Carsten Dominik
2010-06-21 13:08           ` Bernt Hansen
2010-06-21 13:21             ` Carsten Dominik
2010-06-22 21:40               ` [PATCH v2] " Bernt Hansen
2010-06-23 15:26                 ` Carsten Dominik
2010-06-23 15:38                   ` Bernt Hansen
2010-06-23 15:42                     ` Carsten Dominik
2010-07-01 13:00                 ` Carsten Dominik
2010-07-01 13:19                   ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eig05z1v.fsf@gollum.intra.norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).