From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH] Fix agenda display for late scheduled and deadline tasks Date: Mon, 21 Jun 2010 08:51:24 -0400 Message-ID: <87eig05z1v.fsf@gollum.intra.norang.ca> References: <1276358948-19543-1-git-send-email-bernt@norang.ca> <1276359235-19934-1-git-send-email-bernt@norang.ca> <87aaqoimgc.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=36400 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQgTP-00088R-HR for emacs-orgmode@gnu.org; Mon, 21 Jun 2010 08:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQgTL-0007g4-7T for emacs-orgmode@gnu.org; Mon, 21 Jun 2010 08:51:33 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:58402) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQgTL-0007fx-4v for emacs-orgmode@gnu.org; Mon, 21 Jun 2010 08:51:31 -0400 In-Reply-To: <87aaqoimgc.fsf@fastmail.fm> (Matt Lundin's message of "Mon\, 21 Jun 2010 08\:45\:07 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Matt Lundin Cc: emacs-orgmode@gnu.org Matt Lundin writes: > Hi Bernt, > > Bernt Hansen writes: > >> * lisp/org-agenda.el (org-agenda-get-deadlines): >> (org-agenda-get-scheduled): >> * lisp/org.el (org-time-string-to-seconds): >> For deadline and scheduled agenda display ignore the cyclic repeater >> when calculating how many days late the task is. If you have a weekly >> task and miss the date the agenda view will show more than a week late >> now instead of resetting on the cyclic repeating date. This makes it >> much more obvious when you missed a repeating task after the repeater. >> --- >> Updated patch - fixes DAYN -> DAYNR in the docstring. > > I believe this patch breaks the functionality of > org-agenda-repeating-timestamp-show-all. > > I have org-agenda-repeating-timestamp-show-all set to t, but only one > occurrence of each repeating timestamp is shown. Hi Matt, Sorry about that. I don't use org-agenda-repeating-timestamp-show-all. I guess we have two options 1) revert the patch 2) continue with the old behaviour if this variable is set. I'm not sure what is best here -- if we go with option 2) then the agenda display for scheduled and deadline tasks changes based on this variable which may not be obvious. I'll try to post a patch for option 2) later today. Thanks for the feedback. Regards, Bernt