From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Michael Ax <michaelax@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: segfault when org-ellipsis is empty
Date: Mon, 26 Jun 2017 23:42:59 +0200 [thread overview]
Message-ID: <87efu6v318.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY2GSg+Fj-KCjTFwNs789fd21tKw6wietNPWb3=H9Xq=5g@mail.gmail.com> (Kaushal Modi's message of "Mon, 26 Jun 2017 21:13:36 +0000")
Kaushal Modi <kaushal.modi@gmail.com> writes:
> On Mon, Jun 26, 2017 at 4:19 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>>
>> Meanwhile, we could simply change :safe keyword from `org-ellipsis' to
>>
>> (lambda (v) (and (string-or-null-p v) (not (equal v ""))))
>>
>>
>> WDYT?
>>
>
> But that would still allow the user to use setq to set that variable.
True, but can we always prevent them from shooting themselves in the
foot?
Anyway, I updated the :safe value and changed the test below:
(vconcat (mapcar (lambda (c) (make-glyph-code c 'org-ellipsis))
(if (stringp org-ellipsis) org-ellipsis "...")))
Regards,
next prev parent reply other threads:[~2017-06-26 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 18:09 segfault when org-ellipsis is empty Michael Ax
2017-06-26 18:20 ` Kaushal Modi
2017-06-26 20:18 ` Nicolas Goaziou
2017-06-26 21:13 ` Kaushal Modi
2017-06-26 21:42 ` Nicolas Goaziou [this message]
2017-06-26 22:46 ` Michael Ax
2017-06-27 16:26 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efu6v318.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=michaelax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).