From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: segfault when org-ellipsis is empty
Date: Mon, 26 Jun 2017 23:42:59 +0200
Message-ID: <87efu6v318.fsf@nicolasgoaziou.fr>
References: <6b6ee521-a482-0377-6f46-23c91365bee4@gMail.com>
	<CAFyQvY3z2WVEYzueag52r=Y3HieSuJVDvURFFqy47+mYN9aE=g@mail.gmail.com>
	<87zicuv6xb.fsf@nicolasgoaziou.fr>
	<CAFyQvY2GSg+Fj-KCjTFwNs789fd21tKw6wietNPWb3=H9Xq=5g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dPbmh-0007lc-EO
	for emacs-orgmode@gnu.org; Mon, 26 Jun 2017 17:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dPbmg-0004by-R3
	for emacs-orgmode@gnu.org; Mon, 26 Jun 2017 17:43:03 -0400
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:37160)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dPbmg-0004al-Kq
	for emacs-orgmode@gnu.org; Mon, 26 Jun 2017 17:43:02 -0400
In-Reply-To: <CAFyQvY2GSg+Fj-KCjTFwNs789fd21tKw6wietNPWb3=H9Xq=5g@mail.gmail.com>
	(Kaushal Modi's message of "Mon, 26 Jun 2017 21:13:36 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Michael Ax <michaelax@gmail.com>, emacs-orgmode@gnu.org

Kaushal Modi <kaushal.modi@gmail.com> writes:

> On Mon, Jun 26, 2017 at 4:19 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>>
>> Meanwhile, we could simply change :safe keyword from `org-ellipsis' to
>>
>>   (lambda (v) (and (string-or-null-p v) (not (equal v ""))))
>>
>>
>> WDYT?
>>
>
> But that would still allow the user to use setq to set that variable.

True, but can we always prevent them from shooting themselves in the
foot?

Anyway, I updated the :safe value and changed the test below:

  (vconcat (mapcar (lambda (c) (make-glyph-code c 'org-ellipsis))
		   (if (stringp org-ellipsis) org-ellipsis "...")))


Regards,