emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
       [not found] <2ef16fc3-45f7-c2a2-9804-27143db32e3b@eclecticse.com.au>
@ 2019-05-05  9:29 ` Nicolas Goaziou
  2020-05-24  8:22   ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2019-05-05  9:29 UTC (permalink / raw)
  To: David Trudgett; +Cc: 34891

Hello,

David Trudgett <david.trudgett@eclecticse.com.au> writes:

> Reproduce:
>
> In an Org mode file, add a #+DATE tag as follows:
>
> #+DATE: First published: 1 February 2014
>
> Then initiate a project publish, which publishes (by default) only
> changed files. A date such as the above will not be parsed, so
> ox-publish.el will always publish it, even though it has not changed.
> Using instead a parsable date format (such as 2014-02-01), this date will be
> recognised, and will result in the file never being published, because
> it is treating the date as a modification date instead of a creation date.
>
> Desired Behaviour:
>
> ox-publish.el, in function ORG-PUBLISH-FIND-DATE should not be using
> this date to detect modifications, as it will never change, and no
> modifications will be detected for publishing.

I don't understand how you come to this conclusion. 

The function responsible for deciding if a file should be published is
`org-publish-cache-file-needs-publishing'. It doesn't call
`org-publish-find-date', but `org-publish-cache-ctime-of-src'. The
latter only uses `file-attribute-modification-time'.

IOW, I think the file is published because you modified since last
publishing.

WDYT?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
  2019-05-05  9:29 ` bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp Nicolas Goaziou
@ 2020-05-24  8:22   ` Bastien
  0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2020-05-24  8:22 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: David Trudgett, 34891-done

Hi David,

after Nicolas' answer, I don't see the bug in here, so I am closing
this bug report.

If you think there is still something wrong, please test with latest
Org and report it again on emacs-orgmode@gnu.org.

Thanks,

-- 
 Bastien




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
  2020-05-24 20:46 David Trudgett
@ 2020-05-25 10:27 ` Bastien
  0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2020-05-25 10:27 UTC (permalink / raw)
  To: David Trudgett; +Cc: emacs-orgmode

Hi David,

David Trudgett <David.Trudgett@eclecticse.com.au> writes:

> The publishing functionality now appears to be working as it
> should. 

Thanks for confirming!

-- 
 Bastien


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
@ 2020-05-24 20:46 David Trudgett
  2020-05-25 10:27 ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: David Trudgett @ 2020-05-24 20:46 UTC (permalink / raw)
  To: emacs-orgmode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Thank you, Nicolas and Bastien,

Apologies for the late reply.

The publishing functionality now appears to be working as it should. I
haven't changed anything myself, except to update Org. It's possible I
misdiagnosed the cause of the problem.

In any case, should the issue arise again, I will take another look at
it and let you all know.

Thanks for your attention on this one. It's really appreciated!

Kind regards,
David

- -- 
Key fingerprint: 1365 2C8F F9F1 188D C064 FB60 9F79 BB01 EEBF 48E6

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEs/RVZpgrZ1SbH+KGVnbxJ50cKpEFAl7K3RsACgkQVnbxJ50c
KpGIqQ/9FG/AHuo/H74OiMXbCsuUvAbsKo0HpmWP+pK1gDksx4WJ9fbRLd0nUzM6
xeDXo6dBBcFOYkt9u5HyOjC9Xq4x5z4leg6WuC18bGT9uTHVCIfwAyyMR+tAxwvG
kfJdSvfWs4UV3vMTYTotzXQ6DU3hILdUOYSuYIUJBctx2NsN1KKAZNlmb69PTuog
rdq8OBnA2dcYird62bSwPOOuwb8RnFBwqXNZ76O1a3eS5bTWx+TaLxSwFx3FGfzF
9zrFzNv6qMjw+TbAQxJ5kuNooF2l+xJTpszxGg/WZlaQ32S4kH7/vCKeHitoCFAX
z0ZsJevY9QkK2R4I9i3B6l2AAiMqfEICLouNIpQDhxgHB4w1aFlhi2mIUrtzQ7m+
n8SuUVbxYne4IAW7riF63YfHRbGqTWHZeIQ3YH62jcKIze8rhU+UW/1fVTUilVWh
JESIyQMOwZQ1BUVKPhBKrOpa0auxMhHGOj8chh9LBk2v4aj2rwNkwfTfA0GP0yzk
fdhvgUDgad5G6iovWcYi94ZR2oea43EpS6xih+n/hPSmZ7I2HsUP/ibaH7Jscu+F
sSwAohtAJ84l5SIC28LxHlqM/29ZWO21ZrfrXo0/eDX4hhTgKJLsGVtD8mnlXs8z
5SrYsGi/km8GAATmIWv6QfJ1v6jniUMnPks+3PJl9u8A8A1EQDs=
=/F3t
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-25 10:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <2ef16fc3-45f7-c2a2-9804-27143db32e3b@eclecticse.com.au>
2019-05-05  9:29 ` bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp Nicolas Goaziou
2020-05-24  8:22   ` Bastien
2020-05-24 20:46 David Trudgett
2020-05-25 10:27 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).