emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Michaël Cadilhac" <michael@cadilhac.name>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-icalendar: Change dates to today in VEVENT export
Date: Thu, 05 Sep 2019 18:52:55 +0200	[thread overview]
Message-ID: <87ef0ufzx4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADt3fpNqAVDmCHkCSrYaTtpxqCFqQ_c8NNH35iiJJfbFYKuBnQ@mail.gmail.com> ("Michaël Cadilhac"'s message of "Wed, 28 Aug 2019 17:54:51 -0500")

Hello,

Michaël Cadilhac <michael@cadilhac.name> writes:

> Hopefully I didn't miss anything—I've been running the patched version for
> weeks now, so it should be stable in any case.  Patch 0003 above should
> still be OK.

Thank you.

> +(defcustom org-icalendar-summary-uses-tags nil
> +  "Whether tags should be added to the title to create the summary.
> +
> +If a SUMMARY is provided in the entry, this is irrelevant.
> +If non-nil, it can be set to `local-tags' or `all-tags' indicating which tags
> +are used to make up the summary: only tags defined in the current line or all
> +tags including inherited ones, respectively."
> +  :group 'org-export-icalendar
> +  :type '(choice
> +	  (const :tag "Use the tags defined in current line" local-tags)
> +	  (const :tag "Use all tags, including inherited ones" all-tags)
> +	  (const :tag "Do not use tags in summary" nil)))

There are missing keywords (:package-version, :safe).

> +(defun org-icalendar-today-timestamp ()
> +  "Return a TIMESTAMP object for today, at 00:00."
> +  (let ((dt (decode-time)))
> +    (list 'timestamp
> +	  (nconc (list :year-start (nth 5 dt)
> +                    :year-end (nth 5 dt)
> +                    :month-start (nth 4 dt)
> +                    :month-end (nth 4 dt)
> +                    :day-start (nth 3 dt)
> +                    :day-end (nth 3 dt))))))

This function already exists: `org-timestamp-from-time'. Could you use
that instead?

Othewise, LGTM.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-09-05 16:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01 12:47 org-icalendar: Change dates to today in VEVENT export Michaël Cadilhac
2019-02-07 12:31 ` Michaël Cadilhac
2019-02-07 13:30   ` Nicolas Goaziou
2019-02-07 15:04     ` Michaël Cadilhac
2019-02-12  8:34       ` Nicolas Goaziou
2019-08-28 22:54         ` Michaël Cadilhac
2019-09-05 16:52           ` Nicolas Goaziou [this message]
2019-09-15 17:06             ` Michaël Cadilhac
2019-09-16 16:32               ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef0ufzx4.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael@cadilhac.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).