From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-icalendar: Change dates to today in VEVENT export
Date: Thu, 05 Sep 2019 18:52:55 +0200
Message-ID: <87ef0ufzx4.fsf@nicolasgoaziou.fr>
References: <CADt3fpPYPOANZ10PW0a1kL=MWERaWnZGQ0yNXiVqveVZK8HzKw@mail.gmail.com>
 <CADt3fpMpxgrb494-RQaLy0u9i__EqfJ5n=4KVz1U4CpAeZLLqw@mail.gmail.com>
 <87d0o37mkh.fsf@nicolasgoaziou.fr>
 <CADt3fpM52KahUwkJ+MzPJjWLe7P4PpGbpm3jvkCnUekPZMsnxw@mail.gmail.com>
 <87pnrx4d77.fsf@nicolasgoaziou.fr>
 <CADt3fpNqAVDmCHkCSrYaTtpxqCFqQ_c8NNH35iiJJfbFYKuBnQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:43204)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1i5v0K-00076v-4N
 for emacs-orgmode@gnu.org; Thu, 05 Sep 2019 12:53:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1i5v0I-0000SR-Lg
 for emacs-orgmode@gnu.org; Thu, 05 Sep 2019 12:53:03 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51269)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
 id 1i5v0I-0000RV-Fo
 for emacs-orgmode@gnu.org; Thu, 05 Sep 2019 12:53:02 -0400
In-Reply-To: <CADt3fpNqAVDmCHkCSrYaTtpxqCFqQ_c8NNH35iiJJfbFYKuBnQ@mail.gmail.com>
 (=?utf-8?Q?=22Micha=C3=ABl?= Cadilhac"'s message of "Wed, 28 Aug 2019
 17:54:51 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: =?utf-8?Q?Micha=C3=ABl?= Cadilhac <michael@cadilhac.name>
Cc: emacs-orgmode@gnu.org

Hello,

Micha=C3=ABl Cadilhac <michael@cadilhac.name> writes:

> Hopefully I didn't miss anything=E2=80=94I've been running the patched ve=
rsion for
> weeks now, so it should be stable in any case.  Patch 0003 above should
> still be OK.

Thank you.

> +(defcustom org-icalendar-summary-uses-tags nil
> +  "Whether tags should be added to the title to create the summary.
> +
> +If a SUMMARY is provided in the entry, this is irrelevant.
> +If non-nil, it can be set to `local-tags' or `all-tags' indicating which=
 tags
> +are used to make up the summary: only tags defined in the current line o=
r all
> +tags including inherited ones, respectively."
> +  :group 'org-export-icalendar
> +  :type '(choice
> +	  (const :tag "Use the tags defined in current line" local-tags)
> +	  (const :tag "Use all tags, including inherited ones" all-tags)
> +	  (const :tag "Do not use tags in summary" nil)))

There are missing keywords (:package-version, :safe).

> +(defun org-icalendar-today-timestamp ()
> +  "Return a TIMESTAMP object for today, at 00:00."
> +  (let ((dt (decode-time)))
> +    (list 'timestamp
> +	  (nconc (list :year-start (nth 5 dt)
> +                    :year-end (nth 5 dt)
> +                    :month-start (nth 4 dt)
> +                    :month-end (nth 4 dt)
> +                    :day-start (nth 3 dt)
> +                    :day-end (nth 3 dt))))))

This function already exists: `org-timestamp-from-time'. Could you use
that instead?

Othewise, LGTM.

Regards,

--=20
Nicolas Goaziou