From: Nicolas Goaziou <email@example.com> To: Kyle Meyer <firstname.lastname@example.org> Cc: Matt Lundin <email@example.com>, Org Mode List <firstname.lastname@example.org> Subject: Re: [PATCH] Fix moving cursor in org-set-tags-command Date: Sat, 09 May 2020 10:12:36 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Kyle Meyer's message of "Sat, 09 May 2020 01:44:12 +0000") Hello, Kyle Meyer <email@example.com> writes: > I've tried to capture the issues in the tests below. The first added > check would fail before 450452de4 (and its replacement, 44ec473c1). The > second check would fail with 44ec473c1, the third with both 450452de4 > and 44ec473c1. Matt's patch would get past the first three checks, but > fail with the last one, due to the issue you note. All these checks > pass if the string-match call is anchored or replaced by the > skip-chars-backward form you suggest. OK. Thank you for the clarification. Then let's push Matt Lundin's solution (with skip-chars-backward), along with your tests! Regards, -- Nicolas Goaziou
next prev parent reply other threads:[~2020-05-09 8:12 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-08 0:20 Matt Lundin 2020-05-08 2:42 ` Kyle Meyer 2020-05-08 7:53 ` Nicolas Goaziou 2020-05-09 1:44 ` Kyle Meyer 2020-05-09 8:12 ` Nicolas Goaziou [this message] 2020-05-09 20:01 ` Kyle Meyer 2020-05-10 17:39 ` Matthew Lundin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Fix moving cursor in org-set-tags-command' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).