From: Matt Lundin <mdl@imapmail.org> To: Org Mode List <emacs-orgmode@gnu.org> Subject: [PATCH] Fix moving cursor in org-set-tags-command Date: Thu, 07 May 2020 19:20:09 -0500 [thread overview] Message-ID: <871rnvi8g6.fsf@fastmail.fm> (raw) [-- Attachment #1: Type: text/plain, Size: 1194 bytes --] Commit 44ec473c199262d89b372d8a6cd35bed7672164d from Feb. 23 causes org-set-tags-command to move the cursor forward 1 char when situated on headline asterisks. So if I am on the following level 1 headline with the cursor on the asterisk as below... * Headline ^ ...and I call org-set-tags command, it moves the cursor forward one space: * Headline :tag: ^ This is causes problems with org-speed-keys, which requires that the cursor remain on the headline. This commit modified a previous change on Feb. 21 (450452de4b790706d187291f9f71a286f8f62004). But that commit also had problems, since it would move the cursor one asterisk forward on headlines > 1, thus also interfering with org-speed-keys. In my view org-set-tags-command should not move the cursor except to fix the very specific thing that commit 450452de4b was meant to fix: namely the cursor moving when on a blank headline: i.e., from here... *** ^ ...to here... *** :tag: ^ I've attached a patch that corrects the problem, but it would be ideal if we figured out why the cursor is moving in the first place. Best, Matt [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Fix-bug-that-placed-cursor-incorrectly-when-setting-.patch --] [-- Type: text/x-patch, Size: 1012 bytes --] From ae5cf0e1110241426e49f573219e9740c25bf8ea Mon Sep 17 00:00:00 2001 From: Matt Lundin <mdl@imapmail.org> Date: Thu, 7 May 2020 19:06:08 -0500 Subject: [PATCH 1/1] Fix bug that placed cursor incorrectly when setting tags * lisp/org.el: (org-set-tags-command) Only fix cursor position in very specific circumstances (i.e., when cursor is on an empty headline). --- lisp/org.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index dd017e662..0e4fd7be1 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -11846,8 +11846,9 @@ in Lisp code use `org-set-tags' instead." (org-set-tags tags))))) ;; `save-excursion' may not replace the point at the right ;; position. - (when (save-excursion (skip-chars-backward "*") (bolp)) - (forward-char)))) + (and (looking-at " ") + (string-match "\\*+" (buffer-substring (point-at-bol) (point))) + (forward-char)))) (defun org-align-tags (&optional all) "Align tags in current entry. -- 2.26.2
next reply other threads:[~2020-05-08 0:20 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-08 0:20 Matt Lundin [this message] 2020-05-08 2:42 ` Kyle Meyer 2020-05-08 7:53 ` Nicolas Goaziou 2020-05-09 1:44 ` Kyle Meyer 2020-05-09 8:12 ` Nicolas Goaziou 2020-05-09 20:01 ` Kyle Meyer 2020-05-10 17:39 ` Matthew Lundin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=871rnvi8g6.fsf@fastmail.fm \ --to=mdl@imapmail.org \ --cc=emacs-orgmode@gnu.org \ --subject='Re: [PATCH] Fix moving cursor in org-set-tags-command' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).