emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Colin Baxter <m43cap@yandex.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: , emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: org-bibtex does not recognise @Comment
Date: Sat, 28 Aug 2021 17:38:34 +0100	[thread overview]
Message-ID: <87eead34ol.fsf@yandex.com> (raw)
In-Reply-To: <878s0lu23z.fsf@localhost> (Ihor Radchenko's message of "Sat, 28 Aug 2021 21:32:00 +0800")

Hello Ihor,

>>>>> Ihor Radchenko <yantar92@gmail.com> writes:

    > Colin Baxter <m43cap@yandex.com> writes:
    >> I've noticed that "org-bibtex-import-from-file" will not import
    >> from bib files which begin with the standard bibtex mode-line
    >> heading of
    >> 
    >> @Comment -*- mode: bibtex; -*-

    > Well. It will import the files. However, org-bibtex-write will
    > indeed fail. If I got it wrong, please provide more details.

    > Confirmed

    > The fix is attached.

I've applied your patch to my local git branch of org-mode and it works
very nicely. I can live with the write fail you mentioned. Will you
apply it to the master branch of org-mode?

Thank you.

Best wishes,

Colin.


  reply	other threads:[~2021-08-28 16:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  8:37 Colin Baxter
2021-08-28 13:32 ` [PATCH] " Ihor Radchenko
2021-08-28 16:38   ` Colin Baxter [this message]
2021-08-28 16:59     ` Ihor Radchenko
2021-08-28 18:54       ` Colin Baxter
2021-09-26  6:57   ` Bastien
2021-09-26 10:43     ` Colin Baxter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eead34ol.fsf@yandex.com \
    --to=m43cap@yandex.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --subject='Re: [PATCH] Re: org-bibtex does not recognise @Comment' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).