From: Ihor Radchenko <yantar92@gmail.com>
To: Colin Baxter <m43cap@yandex.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: org-bibtex does not recognise @Comment
Date: Sun, 29 Aug 2021 00:59:32 +0800 [thread overview]
Message-ID: <8735qttsi3.fsf@localhost> (raw)
In-Reply-To: <87eead34ol.fsf@yandex.com>
Colin Baxter <m43cap@yandex.com> writes:
> > Well. It will import the files. However, org-bibtex-write will
> > indeed fail. If I got it wrong, please provide more details.
>
> > Confirmed
>
> > The fix is attached.
>
> I've applied your patch to my local git branch of org-mode and it works
> very nicely. I can live with the write fail you mentioned.
Let me clarify. On my side, org-bibtex-read-file did not throw any error
on a .bib file with comment. Is it any different for you?
The patch is supposed to fix org-bibtex-write -- the only problem I was
able to see following your email.
> Will you apply it to the master branch of org-mode?
Nope. We need to wait for the maintainers with write access to apply it.
Best,
Ihor
next prev parent reply other threads:[~2021-08-28 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 8:37 Colin Baxter
2021-08-28 13:32 ` [PATCH] " Ihor Radchenko
2021-08-28 16:38 ` Colin Baxter
2021-08-28 16:59 ` Ihor Radchenko [this message]
2021-08-28 18:54 ` Colin Baxter
2021-09-26 6:57 ` Bastien
2021-09-26 10:43 ` Colin Baxter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735qttsi3.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=m43cap@yandex.com \
--subject='Re: [PATCH] Re: org-bibtex does not recognise @Comment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).