emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* flyspell overlays removed in comments: does this make sense?
@ 2021-12-20 16:56 Eric S Fraga
  2021-12-22 14:10 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Eric S Fraga @ 2021-12-20 16:56 UTC (permalink / raw)
  To: Emacs Org mode mailing list

Hello all,

for some time (years, really), I've suffered with flyspell overlays
disappearing in comments in org documents.  It never occurred to me that
this was due to org itself so I just put up with and chalked it up to
one of those Emacs mysteries.  Today, for unrelated reasons [1], I ended
up looking at the code, specifically

org-fontify-meta-lines-and-blocks-1

and see that org explicitly removes flyspell overlays in comments.

Before I look into maybe adding a user option for the flyspell issue,
can somebody explain the rationale for this?  My comments tend to be
natural languages so flyspell is most definitely useful.  Okay, spelling
errors in comments may matter less in terms of dissemination but
still...

Or have I misunderstood something fundamental?

thank you,
eric


Footnotes:

[1] The unrelated reason is that I was looking at how I could get my own
user-defined meta lines ("#+calc: " for my use of embedded calc in org,
for the curious amongst you) fontified the way I want them.  Not easy,
as far as I can see.  I further noticed that org also removes flyspell
overlays from any "other" meta line, i.e. any other meta line not
processed by specific code.

-- 
: Eric S Fraga, with org release_9.5.1-279-g8908fb in Emacs 29.0.50
: Latest paper written in org: https://arxiv.org/abs/2106.05096


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: flyspell overlays removed in comments: does this make sense?
  2021-12-20 16:56 flyspell overlays removed in comments: does this make sense? Eric S Fraga
@ 2021-12-22 14:10 ` Ihor Radchenko
  2021-12-28 15:01   ` Eric S Fraga
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2021-12-22 14:10 UTC (permalink / raw)
  To: Eric S Fraga; +Cc: Emacs Org mode mailing list

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> for some time (years, really), I've suffered with flyspell overlays
> disappearing in comments in org documents.  It never occurred to me that
> this was due to org itself so I just put up with and chalked it up to
> one of those Emacs mysteries.  Today, for unrelated reasons [1], I ended
> up looking at the code, specifically

Not only comments. Same for #+captions (which made me miss spelling
errors in my figure captions).

> org-fontify-meta-lines-and-blocks-1
>
> and see that org explicitly removes flyspell overlays in comments.
>
> Before I look into maybe adding a user option for the flyspell issue,
> can somebody explain the rationale for this?  My comments tend to be
> natural languages so flyspell is most definitely useful.  Okay, spelling
> errors in comments may matter less in terms of dissemination but
> still...

Looking at git log, the intention was avoiding flyspell highlights in
cases like #+IKNOWTHISISNOTREALWORD: keyword value. Removing the
highlights from user text is a side effect.

I consider this a bug and mark your report as such.

Confirmed

Best,
Ihor


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: flyspell overlays removed in comments: does this make sense?
  2021-12-22 14:10 ` Ihor Radchenko
@ 2021-12-28 15:01   ` Eric S Fraga
  0 siblings, 0 replies; 3+ messages in thread
From: Eric S Fraga @ 2021-12-28 15:01 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Emacs Org mode mailing list

On Wednesday, 22 Dec 2021 at 22:10, Ihor Radchenko wrote:
> I consider this a bug and mark your report as such.

Thank you.  I'm glad I'm not alone!

-- 
: Eric S Fraga, with org release_9.5.1-279-g8908fb in Emacs 29.0.50
: Latest paper written in org: https://arxiv.org/abs/2106.05096


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-28 15:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 16:56 flyspell overlays removed in comments: does this make sense? Eric S Fraga
2021-12-22 14:10 ` Ihor Radchenko
2021-12-28 15:01   ` Eric S Fraga

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).