emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-display-inline-images ignores parameter beg. [7.8.03]
@ 2012-03-26 15:21 Shoji Nishimura
  2012-03-26 20:29 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Shoji Nishimura @ 2012-03-26 15:21 UTC (permalink / raw)
  To: emacs-orgmode

'org-display-inline-images' ignores the optional parameter value of 'beg'.
The help says when we specify 'beg' and 'end', the function displays
inline images between 'beg' and 'end'.
However, it seems to display images between (point-min) and 'end'.


I attach a patch to fix it.

--- org.el.old	2012-03-27 00:17:14.877917316 +0900
+++ org.el	2012-03-27 00:17:34.985916876 +0900
@@ -17121,7 +17121,7 @@
     (save-restriction
       (widen)
       (setq beg (or beg (point-min)) end (or end (point-max)))
-      (goto-char (point-min))
+      (goto-char beg)
       (let ((re (concat "\\[\\[\\(\\(file:\\)\\|\\([./~]\\)\\)\\([^]\n]+?"
 			(substring (org-image-file-name-regexp) 0 -2)
 			"\\)\\]" (if include-linked "" "\\]")))


best regards,
Shoji

Emacs  : GNU Emacs 23.3.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.5)
 of 2011-08-15 on allspice, modified by Debian
Package: Org-mode version 7.8.03

current state:
==============
(setq
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-speed-command-hook '(org-speed-command-default-hook
			  org-babel-speed-command-hook)
 org-babel-load-languages '((R . t) (emacs-lisp . t) (dot . t) (ruby . t))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-babel-tangle-lang-exts '(("ruby" . "rb") ("emacs-lisp" . "el"))
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-src-lang-modes '(("dot" . graphviz-dot) ("ocaml" . tuareg)
		      ("elisp" . emacs-lisp) ("ditaa" . artist)
		      ("asymptote" . asy) ("sqlite" . sql)
		      ("calc" . fundamental) ("C" . c) ("cpp" . c++))
 org-tab-first-hook '(org-hide-block-toggle-maybe
		      org-src-native-tab-command-maybe)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-blank-before-new-entry nil
 org-babel-pre-tangle-hook '(save-buffer)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
		  org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-export-preprocess-before-normalizing-links-hook
'(org-remove-file-link-modifiers)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all
		    append local]
		   5]
		 org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(my-org-toggle-inline-image
			  my-org-toggle-preview-latex org-babel-hash-at-point
			  org-babel-execute-safely-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-export-interblocks '((lob org-babel-exp-lob-one-liners)
			  (src org-babel-exp-inline-src-blocks))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-occur-hook '(org-first-headline-recenter)
 org-from-is-user-regexp "\\<Shoji Nishimura\\>"
 org-export-preprocess-before-selecting-backend-code-hook
'(org-beamer-select-beamer-code)
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
			       org-beamer-auto-fragile-frames
			       org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-export-blocks '((src org-babel-exp-src-block nil)
		     (comment org-export-blocks-format-comment t)
		     (ditaa org-export-blocks-format-ditaa nil)
		     (dot org-export-blocks-format-dot nil))
 )

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: org-display-inline-images ignores parameter beg. [7.8.03]
  2012-03-26 15:21 Bug: org-display-inline-images ignores parameter beg. [7.8.03] Shoji Nishimura
@ 2012-03-26 20:29 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-03-26 20:29 UTC (permalink / raw)
  To: Shoji Nishimura; +Cc: emacs-orgmode

Hi Shoji,

Shoji Nishimura <nishimura.shoji@gmail.com> writes:

> 'org-display-inline-images' ignores the optional parameter value of 'beg'.
> The help says when we specify 'beg' and 'end', the function displays
> inline images between 'beg' and 'end'.
> However, it seems to display images between (point-min) and 'end'.

Applied, thanks.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-26 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-26 15:21 Bug: org-display-inline-images ignores parameter beg. [7.8.03] Shoji Nishimura
2012-03-26 20:29 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).