From: Bastien <bzg@gnu.org>
To: Fabrice Niessen <public-fni-news-TA4HMoP+1wHrZ44/DZwexQ@plane.gmane.org>
Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org
Subject: Re: [PATCH] `org-macro--collect-macros' can collect macro definitions from include files
Date: Wed, 05 Feb 2014 17:17:59 +0100 [thread overview]
Message-ID: <87d2j1y1mw.fsf@bzg.ath.cx> (raw)
In-Reply-To: <86ob2la6e6.fsf@somewhere.org> (Fabrice Niessen's message of "Wed, 05 Feb 2014 17:09:05 +0100")
"Fabrice Niessen" <fni-news-TA4HMoP+1wHrZ44/DZwexQ@public.gmane.org>
writes:
> As the DOCSTRING of the function `org-macro--collect-macros' tells it,
> it "collects macro definitions in current buffer and setup files", not
> from INCLUDE files.
Then your patch should change the docstring too.
I think we want to collect macros from setupfile only,
that's one of the differences between INCLUDE and SETUPFILE.
But I'll let Nicolas review and decide.
--
Bastien
next prev parent reply other threads:[~2014-02-05 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 16:09 [PATCH] `org-macro--collect-macros' can collect macro definitions from include files Fabrice Niessen
2014-02-05 16:17 ` Bastien [this message]
2014-02-05 16:27 ` Nicolas Goaziou
[not found] ` <8738jx34p1.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-05 20:11 ` Fabrice Niessen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2j1y1mw.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org \
--cc=public-fni-news-TA4HMoP+1wHrZ44/DZwexQ@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).