From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] `org-macro--collect-macros' can collect macro definitions from include files Date: Wed, 05 Feb 2014 17:17:59 +0100 Message-ID: <87d2j1y1mw.fsf@bzg.ath.cx> References: <86ob2la6e6.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5BL-0007sx-0g for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:18:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WB5BE-00061U-9i for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:18:34 -0500 Received: from plane.gmane.org ([80.91.229.3]:36421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WB5BD-00061H-TW for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 11:18:28 -0500 Received: from public by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WB5B9-0006F6-0e for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 17:18:23 +0100 In-Reply-To: <86ob2la6e6.fsf@somewhere.org> (Fabrice Niessen's message of "Wed, 05 Feb 2014 17:09:05 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Fabrice Niessen Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org "Fabrice Niessen" writes: > As the DOCSTRING of the function `org-macro--collect-macros' tells it, > it "collects macro definitions in current buffer and setup files", not > from INCLUDE files. Then your patch should change the docstring too. I think we want to collect macros from setupfile only, that's one of the differences between INCLUDE and SETUPFILE. But I'll let Nicolas review and decide. -- Bastien